git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Git Mailing list <git@vger.kernel.org>
Subject: Re: how to most effectively cherry pick by selective patch hunk?
Date: Tue, 9 Feb 2021 11:39:31 -0500	[thread overview]
Message-ID: <YCK6w/VbfUtM68Ad@coredump.intra.peff.net> (raw)
In-Reply-To: <566b38df-307c-f342-b583-3a50a81b5057@crashcourse.ca>

On Tue, Feb 09, 2021 at 08:58:06AM -0500, Robert P. J. Day wrote:

>   what would be great is some sort of "-p" (patch selection) option
> with cherry-pick, but i don't see that.

We have "checkout -p", but of course the problem there is that it's
picking out of the whole state of that commit. So you might see other
changes not introduced by that commit.

Conceptually, adding "cherry-pick -p" would be pretty easy. The strategy
for all of the "-p" options is to generate a diff, then feed that diff
to the patch-selection code, then apply whatever the user selects. For
"checkout -p $commit", that diff is the diff between $commit and our
current state. But for "cherry-pick -p", it would be the diff between
$commit^ and $commit.

Of course that involves a change to Git, and you were looking for
something you could do with existing versions. :) You can emulate it by
making the commit's parent equivalent to your current state. I.e.:

  git checkout --detach ;# detached HEAD for temporary commit
  git cherry-pick $commit ;# maybe deal with conflicts
  commit=$(git rev-parse --verify HEAD) ;# remember the temp commit
  git checkout - ;# back to your branch
  git checkout -p $commit

-Peff

  reply	other threads:[~2021-02-09 16:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 13:58 how to most effectively cherry pick by selective patch hunk? Robert P. J. Day
2021-02-09 16:39 ` Jeff King [this message]
2021-02-09 16:58   ` Robert P. J. Day
2021-02-09 17:12   ` Andreas Schwab
2021-02-11  0:54     ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCK6w/VbfUtM68Ad@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).