From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 382F41F9FD for ; Thu, 18 Feb 2021 19:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232292AbhBRT70 (ORCPT ); Thu, 18 Feb 2021 14:59:26 -0500 Received: from cloud.peff.net ([104.130.231.41]:38020 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231320AbhBRT4z (ORCPT ); Thu, 18 Feb 2021 14:56:55 -0500 Received: (qmail 28521 invoked by uid 109); 18 Feb 2021 19:56:12 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 18 Feb 2021 19:56:12 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23901 invoked by uid 111); 18 Feb 2021 19:56:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 18 Feb 2021 14:56:11 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 18 Feb 2021 14:56:11 -0500 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin , Jonathan Tan Subject: Re: [PATCH v2 10/10] fsck.h: update FSCK_OPTIONS_* for object_name Message-ID: References: <20210217194246.25342-1-avarab@gmail.com> <20210218105840.11989-11-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210218105840.11989-11-avarab@gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Feb 18, 2021 at 11:58:40AM +0100, Ævar Arnfjörð Bjarmason wrote: > Add the object_name member to the initialization macro. This was > omitted in 7b35efd734e (fsck_walk(): optionally name objects on the > go, 2016-07-17) when the field was added. We're correct either way here, because trailing fields that are not initialized will get the usual zero-initialization. But I don't mind trying to be more complete. That said, we have embraced designated initializers these days, in which case we usually omit the NULL ones. So perhaps: #define FSCK_OPTIONS_DEFAULT { \ .walk = fsck_error_function, \ .skiplist = OIDSET_INIT, \ } #define FSCK_OPTIONS_STRICT { \ .walk = fsck_error_function, \ .skiplist = OIDSET_INIT, \ .strict = 1, \ } would be more readable still? -Peff