From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2C6B51F934 for ; Fri, 29 Jan 2021 22:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232939AbhA2WMR (ORCPT ); Fri, 29 Jan 2021 17:12:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232752AbhA2WMO (ORCPT ); Fri, 29 Jan 2021 17:12:14 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEB86C061573 for ; Fri, 29 Jan 2021 14:11:34 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id a19so10346688qka.2 for ; Fri, 29 Jan 2021 14:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hT3uGtHvWDe8JO61wYqEiI4pCsJdxjpC2xE9sbKz0Jw=; b=Ce9CuGWK9TtuPnWMwiDuSxqQSizHnG39buacFmVc0Mpc85m+RFmE5LQbLQnRkerpui WIKQw2GB/NCadMP5KDeReIUmXT8kTkpXLDwptz1yDdxpzJ4IB/0XUGAyUjlffjiwkrX9 f6vojRTYzQyyX189+/JNOD3IiETUUV0NY5EHtUeSY2K7xCFPdTyuisi8i0wyfTDxLjZN iTDu0tU9NMEt5ruCfxuQ4e+V58miijP/tkKK2E20sUrAnBmLkiMrsYmpHDJ/ceOO4hGy DUFJKiksdfwGl9e+OyXEuI0raIJl44PZEhEaLpGT8xJ22JBhAXhgMi2X/cYfE2GGqT/3 iuag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hT3uGtHvWDe8JO61wYqEiI4pCsJdxjpC2xE9sbKz0Jw=; b=qMYC7Ho78vgJJwxATWhGwPDdmFNjQn08+IWCA5r7GwW7buXUa6AKMXCx3rZxoPTj/h i4mrWhvR0clsHd2ZBAtywAyIkHxg4LdD90AmLsTtnuel4EGd44JfzLTkpc3wg1T7qbsW uvHiW1XGzYjqGV8lYwBXc+GDGyAF2LV8O2HCphoYVKtT4NYl2+fZiN/SicZs1dInm8uO 0cebwvKeRkJPxVqokNzgIHlStH1TARgaXSg4QW7SIC7NEMRJXttB8STigQ/uikjRuknJ rIuywDnJkm+fn8yPgMBluq4cnW/nvjYe0XJM+uy823osx02Wi45Yu+dM1dqdBtlItLld txqw== X-Gm-Message-State: AOAM532y2MHg9vRFtAAWkJzJzxSigW9ETw/IdEg2LE3pitxV7wVanv92 Qst4xogC4fydIsuHfxLVPtd5LQ== X-Google-Smtp-Source: ABdhPJx/ksyqpoZAPcICWG02gt4BTZb4yXYLsLkPfyD/ouGHfcL/t8EKGKMjBJdNfMV+sfwluTd9Lw== X-Received: by 2002:a37:ad4:: with SMTP id 203mr6166050qkk.125.1611958293979; Fri, 29 Jan 2021 14:11:33 -0800 (PST) Received: from localhost ([2605:9480:22e:ff10:f05a:e493:9aaa:4c8c]) by smtp.gmail.com with ESMTPSA id t8sm6799624qkt.125.2021.01.29.14.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 14:11:33 -0800 (PST) Date: Fri, 29 Jan 2021 17:11:31 -0500 From: Taylor Blau To: Eric Sunshine Cc: Jeff King , Junio C Hamano , Taylor Blau , Git List , Derrick Stolee Subject: Re: [PATCH] p5303: avoid sed GNU-ism Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jan 29, 2021 at 03:36:01PM -0500, Eric Sunshine wrote: > On Fri, Jan 29, 2021 at 3:28 PM Jeff King wrote: > > On Fri, Jan 29, 2021 at 03:19:31PM -0500, Eric Sunshine wrote: > > > It's not just exotic platforms on which this can be a problem. BSD > > > lineage `sed`, such as stock `sed` on macOS, doesn't understand this > > > notation. > > > > OK, then I'm doubly surprised nobody has noticed and complained about > > this. :) > > Aside from there possibly being relatively few regular Git developers > using macOS, it could also be because it's difficult to run the perf > tests on macOS in the first place due to the GNU prerequisites. For > instance, the perf tests have an unconditional dependency on GNU > `time` which is not installed on macOS by default, and it's not always > easy to figure out how to obtain it. Yep, I agree completely. I was going to say that this would produce a conflict (albeit, a trivial one) with the series that this came out of. But I think that we're better off abandoning that series for now until I send a different version, so I think we should just go ahead an apply this. Thanks, Taylor