From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 881201F4B4 for ; Fri, 29 Jan 2021 20:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233181AbhA2UbA (ORCPT ); Fri, 29 Jan 2021 15:31:00 -0500 Received: from cloud.peff.net ([104.130.231.41]:40822 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233328AbhA2U2n (ORCPT ); Fri, 29 Jan 2021 15:28:43 -0500 Received: (qmail 3708 invoked by uid 109); 29 Jan 2021 20:27:32 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 29 Jan 2021 20:27:32 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 8830 invoked by uid 111); 29 Jan 2021 20:27:55 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 29 Jan 2021 15:27:55 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 29 Jan 2021 15:27:55 -0500 From: Jeff King To: Eric Sunshine Cc: Junio C Hamano , Taylor Blau , Git List , Derrick Stolee Subject: Re: [PATCH] p5303: avoid sed GNU-ism Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jan 29, 2021 at 03:19:31PM -0500, Eric Sunshine wrote: > On Fri, Jan 29, 2021 at 3:07 PM Jeff King wrote: > > Subject: [PATCH] p5303: avoid sed GNU-ism > > > > Using "1~5" isn't portable. Nobody seems to have noticed, since perhaps > > people don't tend to run the perf suite on more exotic platforms. Still, > > it's better to set a good example. > > It's not just exotic platforms on which this can be a problem. BSD > lineage `sed`, such as stock `sed` on macOS, doesn't understand this > notation. > > Thanks for eliminating this particular GNU-ism. OK, then I'm doubly surprised nobody has noticed and complained about this. :) -Peff