From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jacob Vosmaer <jacob@gitlab.com>,
Jeff Hostetler <jeffhost@microsoft.com>,
Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH] run-command: document use_shell option
Date: Fri, 22 Jan 2021 19:04:55 -0500 [thread overview]
Message-ID: <YAtoJ1ooPn9sdoGL@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqzh1062as.fsf@gitster.c.googlers.com>
On Fri, Jan 22, 2021 at 02:21:15PM -0800, Junio C Hamano wrote:
> > - unsigned stdout_to_stderr:1;
> > + /**
> > + * Run the command from argv[0] using a shell (but note that we may
> > + * still optimize out the shell call if the command contains no
> > + * metacharacters). Note that further arguments to the command in
> > + * argv[1], etc, do not need to be shell-quoted.
> > + */
> > unsigned use_shell:1;
> > +
> > + unsigned stdout_to_stderr:1;
>
> Reads well. Thanks.
>
> It is curious why "diff" chose to move stdout_to_stderr line around,
> though.
Heh, I also noticed that and tried a few options to no avail (both
patience/histogram, but also diff.indentHeuristic). It is one deletion
and 8 insertions even if it is done the other way:
+ /*
+ ... 6 more lines ...
+ */
+ unsigned use_shell:1;
+
unsigned stdout_to_stderr:1;
- unsigned use_shell:1;
so it may just come down to the order of xdiff parsing the lines.
-Peff
next prev parent reply other threads:[~2021-01-23 0:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 14:21 [PATCH 0/1] upload-pack.c: fix filter spec quoting bug Jacob Vosmaer
2021-01-22 14:21 ` [PATCH 1/1] " Jacob Vosmaer
2021-01-22 20:32 ` Jeff King
2021-01-22 21:03 ` [PATCH] run-command: document use_shell option Jeff King
2021-01-22 21:32 ` Taylor Blau
2021-01-22 22:21 ` Junio C Hamano
2021-01-23 0:04 ` Jeff King [this message]
2021-01-22 22:10 ` [PATCH 1/1] upload-pack.c: fix filter spec quoting bug Junio C Hamano
2021-01-25 17:09 ` [PATCH v2] " Jacob Vosmaer
2021-01-25 19:48 ` Junio C Hamano
2021-01-25 21:16 ` Jeff King
2021-01-25 23:09 ` [PATCH v3 0/1] " Jacob Vosmaer
2021-01-25 23:09 ` [PATCH v3 1/1] " Jacob Vosmaer
2021-01-26 9:57 ` Ævar Arnfjörð Bjarmason
2021-01-26 10:29 ` Jacob Vosmaer
2021-01-26 17:46 ` Junio C Hamano
2021-01-26 21:09 ` Jeff King
2021-01-28 16:04 ` [PATCH v4] " Jacob Vosmaer
[not found] ` <xmqqmtwsx4d9.fsf@gitster.c.googlers.com>
2021-01-28 21:12 ` Jacob Vosmaer
2021-01-28 21:40 ` Jacob Vosmaer
2021-01-28 21:51 ` Jeff King
2021-02-01 20:31 ` Jacob Vosmaer
2021-01-28 21:58 ` Junio C Hamano
2021-02-01 20:29 ` [PATCH v5 0/1] " Jacob Vosmaer
2021-02-01 20:29 ` [PATCH v5 1/1] " Jacob Vosmaer
2021-02-02 5:49 ` [PATCH v5 0/1] " Junio C Hamano
2021-02-02 10:37 ` [PATCH 1/1] t5544: clarify 'hook works with partial clone' test Jacob Vosmaer
2021-02-02 17:22 ` Eric Sunshine
2021-02-02 19:24 ` [PATCH v2] " Jacob Vosmaer
2021-02-02 20:21 ` Junio C Hamano
2021-01-26 17:51 ` [PATCH v3 1/1] upload-pack.c: fix filter spec quoting bug Junio C Hamano
2021-01-26 21:07 ` Jeff King
2021-01-26 0:01 ` [PATCH v3 0/1] " Junio C Hamano
2021-01-26 2:25 ` [PATCH v2] " Junio C Hamano
2021-01-25 21:16 ` Jeff King
2021-01-25 17:14 ` [PATCH 1/1] " Jacob Vosmaer
2021-01-25 17:41 ` Jacob Vosmaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAtoJ1ooPn9sdoGL@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob@gitlab.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).