From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 579031F4B4 for ; Sat, 23 Jan 2021 00:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726158AbhAVX7n (ORCPT ); Fri, 22 Jan 2021 18:59:43 -0500 Received: from cloud.peff.net ([104.130.231.41]:36022 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbhAVX6S (ORCPT ); Fri, 22 Jan 2021 18:58:18 -0500 Received: (qmail 15703 invoked by uid 109); 22 Jan 2021 23:57:36 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 22 Jan 2021 23:57:36 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 20353 invoked by uid 111); 22 Jan 2021 23:57:37 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 22 Jan 2021 18:57:37 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 22 Jan 2021 18:57:35 -0500 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com, jrnieder@gmail.com Subject: Re: [PATCH v2 4/8] builtin/pack-objects.c: respect 'pack.writeReverseIndex' Message-ID: References: <68bde3ea972f5b3753d7e9063d0490c67c74709b.1610576805.git.me@ttaylorr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <68bde3ea972f5b3753d7e9063d0490c67c74709b.1610576805.git.me@ttaylorr.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Jan 13, 2021 at 05:28:19PM -0500, Taylor Blau wrote: > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c > index 5b0c4489e2..d784569200 100644 > --- a/builtin/pack-objects.c > +++ b/builtin/pack-objects.c > @@ -2955,6 +2955,13 @@ static int git_pack_config(const char *k, const char *v, void *cb) > pack_idx_opts.version); > return 0; > } > + if (!strcmp(k, "pack.writereverseindex")) { > + if (git_config_bool(k, v)) > + pack_idx_opts.flags |= WRITE_REV; > + else > + pack_idx_opts.flags &= ~WRITE_REV; > + return 0; > + } This turned out delightfully simple. And I guess this is the "why is WRITE_REV" caller I asked about from patch 2. It is finish_tmp_packfile() where the magic happens. That unconditionally calls write_rev_file(), but it's a noop if WRITE_REV isn't specified. Makes sense. -Peff