git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
	Jacob Vosmaer <jacob@gitlab.com>
Subject: Re: [PATCH] refs: switch peel_ref() to peel_iterated_oid()
Date: Wed, 20 Jan 2021 15:10:39 -0500	[thread overview]
Message-ID: <YAiOPzOT52v+dOgL@nand.local> (raw)
In-Reply-To: <YAiIK+/hSRxaUx/K@coredump.intra.peff.net>

On Wed, Jan 20, 2021 at 02:44:43PM -0500, Jeff King wrote:
> This has been bugging me for years, and came up again in:
>
>   https://lore.kernel.org/git/YAhXw9Gvn5Pyvacq@coredump.intra.peff.net/
>
> so I decided to finally do something about it. There's a minor textual
> conflict with the caller being touched in that thread, but it's easy to
> resolve. So I think it's OK to consider the two independent.
>
> The commit message turned out rather long. I hope that doesn't scare
> anybody away, but I wanted to cover all of the bases.

Thanks for all of the detail. Suffice it to say, I was not scared away,
and am in fact quite comfortable with this direction.

Sorry for sending such a short response to such a long email, but I
agree with the discussion in the patch message, and I don't have
anything to add other than my approval and a:

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor

  reply	other threads:[~2021-01-20 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 19:44 [PATCH] refs: switch peel_ref() to peel_iterated_oid() Jeff King
2021-01-20 20:10 ` Taylor Blau [this message]
2021-01-22 21:38   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAiOPzOT52v+dOgL@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=jacob@gitlab.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).