From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, Jacob Vosmaer <jacob@gitlab.com>,
git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
Date: Wed, 20 Jan 2021 11:19:41 -0500 [thread overview]
Message-ID: <YAhYHUcdynbWyhwo@nand.local> (raw)
In-Reply-To: <YAhXw9Gvn5Pyvacq@coredump.intra.peff.net>
On Wed, Jan 20, 2021 at 11:18:11AM -0500, Jeff King wrote:
> So I think both the existing and the new calls using for_each_tag_ref()
> are OK here.
Indeed, I followed the same trail of calls as you did and reached the
same conclusion, but didn't write any of it down here since I thought it
wasn't worthwhile.
But, yes, I agree that both are safe.
Thanks,
Taylor
next prev parent reply other threads:[~2021-01-20 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 12:45 [PATCH v2 0/1] builtin/pack-objects.c: avoid iterating all refs Jacob Vosmaer
2021-01-20 12:45 ` [PATCH v2 1/1] " Jacob Vosmaer
2021-01-20 14:49 ` Taylor Blau
2021-01-20 16:18 ` Jeff King
2021-01-20 16:19 ` Taylor Blau [this message]
2021-01-20 18:49 ` Jacob Vosmaer
2021-01-20 19:45 ` Jeff King
2021-01-20 21:46 ` Jacob Vosmaer
2021-01-20 21:52 ` Taylor Blau
2021-01-21 2:54 ` Jeff King
2021-01-22 16:46 ` Jacob Vosmaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAhYHUcdynbWyhwo@nand.local \
--to=me@ttaylorr.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob@gitlab.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).