git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2021, #02; Fri, 8)
Date: Fri, 15 Jan 2021 14:52:05 -0500	[thread overview]
Message-ID: <YAHyZbJNhvZUowIq@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqk0sni68g.fsf@gitster.c.googlers.com>

On Fri, Jan 08, 2021 at 11:22:23AM -0800, Junio C Hamano wrote:

> * ps/config-env-pairs (2021-01-06) 8 commits
>  - config: allow specifying config entries via envvar pairs
>  - environment: make `getenv_safe()` a public function
>  - config: parse more robust format in GIT_CONFIG_PARAMETERS
>  - config: store "git -c" variables using more robust format
>  - config: extract function to parse config pairs
>  - quote: make sq_dequote_step() a public function
>  - config: add new way to pass config via `--config-env`
>  - git: add `--super-prefix` to usage string
> 
>  Introduce two new ways to feed configuration variable-value pairs
>  via environment variables, and tweak the way GIT_CONFIG_PARAMETERS
>  encodes variable/value pairs to make it more robust.
> 
>  Ready for 'next'?

I looked over the first 7, and noticed two of the patches are flipped in
roder (I sent a separate reply in the thread, but I wanted to catch your
attention, since I guess this may be on the list for integrating today).

I didn't see any problems in the code of the 8th one, but I didn't spend
a lot of brain power thinking about the overall design. I feel like that
was hashed out pretty well in the early discussions, though.

-Peff

  parent reply	other threads:[~2021-01-15 19:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 19:22 What's cooking in git.git (Jan 2021, #02; Fri, 8) Junio C Hamano
2021-01-09 10:55 ` Ævar Arnfjörð Bjarmason
2021-01-09 21:28   ` Junio C Hamano
2021-01-09 22:05     ` brian m. carlson
2021-01-09 23:20       ` Junio C Hamano
2021-01-11  1:53         ` brian m. carlson
2021-01-11 19:04           ` Junio C Hamano
2021-01-12 14:00             ` Ævar Arnfjörð Bjarmason
2021-01-14 23:52               ` Emily Shaffer
2021-01-14 23:56                 ` Emily Shaffer
2021-01-15  7:22                   ` Junio C Hamano
2021-01-15  0:29                 ` brian m. carlson
2021-01-15  1:44                 ` Junio C Hamano
2021-01-16 16:23                 ` Ævar Arnfjörð Bjarmason
2021-01-17 17:15                   ` Jeff King
2021-01-17 20:22                     ` Ævar Arnfjörð Bjarmason
2021-01-10 19:00     ` Ævar Arnfjörð Bjarmason
2021-01-11  0:21       ` Junio C Hamano
2021-01-09 21:38 ` David Aguilar
2021-01-09 23:08   ` Junio C Hamano
2021-01-14 23:06 ` Emily Shaffer
2021-01-15  1:50   ` Junio C Hamano
2021-01-15  2:24     ` Taylor Blau
2021-01-15  2:44       ` Taylor Blau
2021-01-15  2:36   ` Derrick Stolee
2021-01-15  2:54     ` Derrick Stolee
2021-01-15  6:36     ` Junio C Hamano
2021-01-15  6:38       ` Junio C Hamano
2021-01-15 11:36         ` Derrick Stolee
2021-01-15 19:44           ` Junio C Hamano
2021-01-15 20:08             ` Emily Shaffer
2021-01-15 20:59               ` Junio C Hamano
2021-01-15 19:52 ` Jeff King [this message]
2021-01-15 21:40   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAHyZbJNhvZUowIq@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).