From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A393E1FA12 for ; Fri, 15 Jan 2021 19:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732549AbhAOTR2 (ORCPT ); Fri, 15 Jan 2021 14:17:28 -0500 Received: from cloud.peff.net ([104.130.231.41]:57566 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726434AbhAOTR1 (ORCPT ); Fri, 15 Jan 2021 14:17:27 -0500 Received: (qmail 3617 invoked by uid 109); 15 Jan 2021 19:16:47 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 15 Jan 2021 19:16:47 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 32376 invoked by uid 111); 15 Jan 2021 19:16:47 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 15 Jan 2021 14:16:47 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 15 Jan 2021 14:16:46 -0500 From: Jeff King To: Patrick Steinhardt Cc: git@vger.kernel.org, Simon Ruderich , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Junio C Hamano , "brian m. carlson" , Philip Oakley Subject: Re: [PATCH v8 5/8] config: store "git -c" variables using more robust format Message-ID: References: <36c2a51b13e463a4aa8e5316447336927153d99d.1610453228.git.ps@pks.im> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <36c2a51b13e463a4aa8e5316447336927153d99d.1610453228.git.ps@pks.im> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jan 12, 2021 at 01:27:01PM +0100, Patrick Steinhardt wrote: > The previous commit added a new format for $GIT_CONFIG_PARAMETERS which > is able to robustly handle subsections with "=" in them. Let's start It looks like this commit and 6 got flipped from the original ordering (it's the "previous commit" talked about here). And indeed, running the tests on the individual commits in this series shows that we fail at this step (because we are writing the new format, but the reader is too strict to accept it). That doesn't matter to the end result, of course, but it hurts later bisecting. Just flipping patches 5 and 6 makes it all work. -Peff