From: Jeff King <peff@peff.net>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: t5559 breaks with apache 2.4.55
Date: Sun, 29 Jan 2023 01:35:28 -0500 [thread overview]
Message-ID: <Y9YTsF4a8lL7uHm+@coredump.intra.peff.net> (raw)
In-Reply-To: <Y9Jmfg/jlSszVep4@coredump.intra.peff.net>
On Thu, Jan 26, 2023 at 06:39:42AM -0500, Jeff King wrote:
> Yeah, after seeing that, I'm quite sure this is a mod_http2 issue. It
> would be nice to bisect within the mod_http2 history to find the
> culprit, but I'd first have to figure out how to build standalone apache
> modules. ;)
This turned out to be quite painless, so I bisected using the source at:
https://github.com/icing/mod_h2
Unfortunately, it's not super helpful for identifying the problem. The
culprit turns out to be 16ffed9692b, which has a 450-line diff. The
commit message is:
* refactored stream response handling to reflect the different phases
(response/data/trailers) more clearly and help resolving cpu busy loops.
But that does at least give me more confidence that the bug is in
mod_http2, and isn't, say, some intentional behavior change there that
happens to trigger a bug in curl.
I opened an issue here: https://github.com/icing/mod_h2/issues/243
So we'll see if that helps.
I re-read your earlier thread, and the version problems you have don't
quite line up. I think you were having issues with mod_http2 2.0.9, but
the older version (1.5.19) worked. I was OK with 2.0.9, but upgrading to
2.0.10 broke things. I'd hate to have to disable t5559 by default; it
does catch some cases that would trigger in the real-world (since real
sites like GitHub are using http2). But if it's too unreliable in
practice, that might be the path of least resistance.
-Peff
next prev parent reply other threads:[~2023-01-29 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 8:00 t5559 breaks with apache 2.4.55 Jeff King
2023-01-22 16:33 ` Todd Zullinger
2023-01-26 11:39 ` Jeff King
2023-01-29 6:35 ` Jeff King [this message]
2023-02-09 21:45 ` Junio C Hamano
2023-02-11 2:20 ` Jeff King
2023-02-11 2:34 ` Junio C Hamano
2023-02-11 3:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9YTsF4a8lL7uHm+@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).