From: Jeff King <peff@peff.net>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] t/lib-httpd: bump required apache version to 2.2
Date: Fri, 3 Feb 2023 12:19:31 -0500 [thread overview]
Message-ID: <Y91CI1NKcy4pEzjn@coredump.intra.peff.net> (raw)
In-Reply-To: <Y9s+ifALGYniOVHK@pobox.com>
On Wed, Feb 01, 2023 at 11:39:37PM -0500, Todd Zullinger wrote:
> > diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh
> > index 608949ea80..8fc411ff41 100644
> > --- a/t/lib-httpd.sh
> > +++ b/t/lib-httpd.sh
> > @@ -99,16 +99,19 @@ then
> > fi
> >
> > HTTPD_VERSION=$($LIB_HTTPD_PATH -v | \
>
> Trivial, but is it worth getting rid of the unnecessary
> backslash, while you're improving things here? Maybe that's
> a mild tangent for code that's otherwise not adjusted very
> often?
Heh, I didn't even notice. I don't think it's a big deal either way. It
definitely doesn't match our style, and I don't mind if we fix it on
top, but it could just be left alone.
It might make more sense as part of a broader cleanup. Running:
git grep '| \\'
turns up a number of hits.
-Peff
next prev parent reply other threads:[~2023-02-03 17:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 11:35 [PATCH 0/4] t/lib-httpd ssl fixes Jeff King
2023-02-01 11:37 ` [PATCH 1/4] t/lib-httpd: bump required apache version to 2.2 Jeff King
2023-02-02 4:39 ` Todd Zullinger
2023-02-03 17:19 ` Jeff King [this message]
2023-02-01 11:38 ` [PATCH 2/4] t/lib-httpd: bump required apache version to 2.4 Jeff King
2023-02-01 11:39 ` [PATCH 3/4] t/lib-httpd: drop SSLMutex config Jeff King
2023-02-01 11:39 ` [PATCH 4/4] t/lib-httpd: increase ssl key size to 2048 bits Jeff King
2023-02-02 4:27 ` [PATCH 0/4] t/lib-httpd ssl fixes Todd Zullinger
2023-02-03 17:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y91CI1NKcy4pEzjn@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).