git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jack Adrian Zappa <adrianh.bsc@gmail.com>
Cc: git-mailing-list <git@vger.kernel.org>
Subject: Re: Redirect isn't working:
Date: Fri, 20 Jan 2023 01:46:51 +0000	[thread overview]
Message-ID: <Y8nyi2QxQN0+kOOk@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <CAKepmaibtbRsKqmiZEtDNoLHWr=JyZ7Fhang4dnmw5ROGmBQTQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

On 2023-01-19 at 18:06:17, Jack Adrian Zappa wrote:
> Here is the filled out form for submitting a bug report:
> 
> What did you do before the bug happened? (Steps to reproduce your issue)
> 
>   At the command line, I typed the following command:
> 
>   $ git diff --no-index --word-diff --color=always <(od -An -t x1
> -w10000000000 file1.txt) <(od -An -t x1 -w10000000000 file2.txt)
> 
> What did you expect to happen? (Expected behavior)
> 
>   I expected to see the diff of the two files.
> 
> What happened instead? (Actual behavior)
> 
>   Instead I saw this:
> 
>   error: Could not access '/proc/1961/fd/63'
> 
> What's different between what you expected and what actually happened?
> 
>   The difference is that I would get the difference between the two
> files as opposed to a critical failure message.

Thanks for the report.  This has come up before (and I attempted a
patch), but the ultimate problem here is that the /proc/PID/fd/* files
are symlinks on Linux, and instead of dereferencing symlinks, Git tries
to read them and print where they point to.  That doesn't work in this
case because the symlinks are symlinks to anonymous pipes, which can't
be resolved.

On other systems, the behaviour may be different because those files may
be represented differently.

My patch attempted to solve this by simply opening the contents instead
of stat'ing them as normal, but I think we found some edge cases and it
didn't get finished.  Note that this behaviour is what plain diff does
because it doesn't handle symlinks at all.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2023-01-20  1:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 18:06 Redirect isn't working: Jack Adrian Zappa
2023-01-20  1:46 ` brian m. carlson [this message]
2023-03-27  9:38   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8nyi2QxQN0+kOOk@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=adrianh.bsc@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).