From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 439811F47C for ; Mon, 16 Jan 2023 17:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235042AbjAPRhQ (ORCPT ); Mon, 16 Jan 2023 12:37:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234991AbjAPRgo (ORCPT ); Mon, 16 Jan 2023 12:36:44 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57C753F2AA for ; Mon, 16 Jan 2023 09:13:19 -0800 (PST) Received: (qmail 15219 invoked by uid 109); 16 Jan 2023 17:13:18 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 16 Jan 2023 17:13:18 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 31669 invoked by uid 111); 16 Jan 2023 17:13:15 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 16 Jan 2023 12:13:15 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 16 Jan 2023 12:13:14 -0500 From: Jeff King To: Ramsay Jones Cc: Junio C Hamano , Daniel Stenberg , Patrick Monnerat , git@vger.kernel.org Subject: Re: [PATCH] ci: do not die on deprecated-declarations warning Message-ID: References: <6d826cd9-e447-8df9-83b9-8deb32d6063d@ramsayjones.plus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6d826cd9-e447-8df9-83b9-8deb32d6063d@ramsayjones.plus.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jan 16, 2023 at 12:39:39AM +0000, Ramsay Jones wrote: > > By the way, it seemed odd to me that this failed in just the linux-musl > > job, and not elsewhere (nor on my development machine, which has curl > > 7.87.0). It looks like there's a bad interaction within curl between the > > typecheck and deprecation macros. Here's a minimal reproduction: > > > > -- >8 -- > > cat >foo.c <<-\EOF > > #include > > void foo(CURL *c) > > { > > curl_easy_setopt(c, CURLOPT_PROTOCOLS, 0); > > } > > EOF > > > > # this will complain about deprecated CURLOPT_PROTOCOLS > > gcc -DCURL_DISABLE_TYPECHECK -Wdeprecated-declarations -c foo.c > > > > # this will not > > gcc -Wdeprecated-declarations -c foo.c > > -- 8< -- > > FYI, I just tried this on cygwin and both gcc invocations above > complain about deprecated CURLOPT_PROTOCOLS. (On Linux I have > curl 7.81.0, so I can't test there). It did work on Linux for me, of course, using 7.87.0. But curiously this morning it behaved differently! In the meantime, Debian's libcurl packaging picked up this upstream patch (and I upgraded): https://github.com/curl/curl/commit/e2aed004302e51cfa5b6ce8c8ab65ef92aa83196 and now the deprecation warning happens consistently. So I think on the curl side there is nothing left to do. -Peff