git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] git-bisect-lk2009: update java code conventions link
@ 2023-01-10  8:38 Andrei Rybak
  2023-01-10  9:32 ` [PATCH v2 0/2] update references in git-bisect-lk2009.txt Andrei Rybak
  0 siblings, 1 reply; 5+ messages in thread
From: Andrei Rybak @ 2023-01-10  8:38 UTC (permalink / raw)
  To: git; +Cc: Christian Couder, Jeff King

A reference to Java Code Conventions in git-bisect-lk2009.txt uses an
outdated URL that redirects to table of contents for the conventions.
The actual claim about "80%" that this reference backs up is on the
first page of the conventions:

  https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html

Use this newer URL and its title in the reference.

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
 Documentation/git-bisect-lk2009.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt
index f3d9566c89..36168792ee 100644
--- a/Documentation/git-bisect-lk2009.txt
+++ b/Documentation/git-bisect-lk2009.txt
@@ -1348,7 +1348,7 @@ References
 ----------
 
 - [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'.  Nist Planning Report 02-3], see Executive Summary and Chapter 8.
-- [[[2]]] http://www.oracle.com/technetwork/java/codeconvtoc-136057.html['Code Conventions for the Java Programming Language'. Sun Microsystems.]
+- [[[2]]] https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html['Code Conventions for the Java Programming Language: 1. Introduction'. Sun Microsystems.]
 - [[[3]]] https://en.wikipedia.org/wiki/Software_maintenance['Software maintenance'. Wikipedia.]
 - [[[4]]] https://lore.kernel.org/git/7vps5xsbwp.fsf_-_@assigned-by-dhcp.cox.net/[Junio C Hamano. 'Automated bisect success story'.]
 - [[[5]]] https://lwn.net/Articles/317154/[Christian Couder. 'Fully automated bisecting with "git bisect run"'. LWN.net.]
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 0/2] update references in git-bisect-lk2009.txt
  2023-01-10  8:38 [PATCH] git-bisect-lk2009: update java code conventions link Andrei Rybak
@ 2023-01-10  9:32 ` Andrei Rybak
  2023-01-10  9:32   ` [PATCH v2 1/2] git-bisect-lk2009: update java code conventions link Andrei Rybak
  2023-01-10  9:32   ` [PATCH v2 2/2] git-bisect-lk2009: update nist report link Andrei Rybak
  0 siblings, 2 replies; 5+ messages in thread
From: Andrei Rybak @ 2023-01-10  9:32 UTC (permalink / raw)
  To: git; +Cc: Christian Couder, Jeff King

While double-checking the patch I noticed that nist.gov link is also dead.

Changes since v1:

 * new second patch which fixes nist report link

Andrei Rybak (2):
  git-bisect-lk2009: update java code conventions link
  git-bisect-lk2009: update nist report link

 Documentation/git-bisect-lk2009.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.38.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] git-bisect-lk2009: update java code conventions link
  2023-01-10  9:32 ` [PATCH v2 0/2] update references in git-bisect-lk2009.txt Andrei Rybak
@ 2023-01-10  9:32   ` Andrei Rybak
  2023-01-10  9:32   ` [PATCH v2 2/2] git-bisect-lk2009: update nist report link Andrei Rybak
  1 sibling, 0 replies; 5+ messages in thread
From: Andrei Rybak @ 2023-01-10  9:32 UTC (permalink / raw)
  To: git; +Cc: Christian Couder, Jeff King

A reference to Java Code Conventions in git-bisect-lk2009.txt uses an
outdated URL that redirects to table of contents for the conventions.
The actual claim about "80%" that this reference backs up is on the
first page of the conventions:

  https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html

Use this newer URL and its title in the reference.

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
 Documentation/git-bisect-lk2009.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt
index f3d9566c89..36168792ee 100644
--- a/Documentation/git-bisect-lk2009.txt
+++ b/Documentation/git-bisect-lk2009.txt
@@ -1348,7 +1348,7 @@ References
 ----------
 
 - [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'.  Nist Planning Report 02-3], see Executive Summary and Chapter 8.
-- [[[2]]] http://www.oracle.com/technetwork/java/codeconvtoc-136057.html['Code Conventions for the Java Programming Language'. Sun Microsystems.]
+- [[[2]]] https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html['Code Conventions for the Java Programming Language: 1. Introduction'. Sun Microsystems.]
 - [[[3]]] https://en.wikipedia.org/wiki/Software_maintenance['Software maintenance'. Wikipedia.]
 - [[[4]]] https://lore.kernel.org/git/7vps5xsbwp.fsf_-_@assigned-by-dhcp.cox.net/[Junio C Hamano. 'Automated bisect success story'.]
 - [[[5]]] https://lwn.net/Articles/317154/[Christian Couder. 'Fully automated bisecting with "git bisect run"'. LWN.net.]
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] git-bisect-lk2009: update nist report link
  2023-01-10  9:32 ` [PATCH v2 0/2] update references in git-bisect-lk2009.txt Andrei Rybak
  2023-01-10  9:32   ` [PATCH v2 1/2] git-bisect-lk2009: update java code conventions link Andrei Rybak
@ 2023-01-10  9:32   ` Andrei Rybak
  2023-01-10 12:26     ` Jeff King
  1 sibling, 1 reply; 5+ messages in thread
From: Andrei Rybak @ 2023-01-10  9:32 UTC (permalink / raw)
  To: git; +Cc: Christian Couder, Jeff King

Commit d656218a83 (docs/bisect-lk2009: update nist report link,
2017-04-20) replaced a dead link to news release on nist.gov.  However,
this might be confusing to the reader (like myself) because the article
git-bisect-lk2009.txt quotes from the news release but the exact quote
cannot be found in the full report.  In addition to that, the link added
in 2017 is also dead in 2023.

Replace the reference to nist.gov with an version of the original NIST
news release archived to the Wayback Machine.  Include also an updated
link to a live version of the full report.

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
 Documentation/git-bisect-lk2009.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I wasn't sure about inclusion of links to https://web.archive.org, but there is
a single precedent already in "Documentation/gitcore-tutorial.txt".

diff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt
index 36168792ee..0bc165788e 100644
--- a/Documentation/git-bisect-lk2009.txt
+++ b/Documentation/git-bisect-lk2009.txt
@@ -1347,7 +1347,7 @@ author to given a talk and for publishing this paper.
 References
 ----------
 
-- [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'.  Nist Planning Report 02-3], see Executive Summary and Chapter 8.
+- [[[1]]] https://web.archive.org/web/20091206032101/http://www.nist.gov/public_affairs/releases/n02-10.htm['Software Errors Cost U.S. Economy $59.5 Billion Annually'. Nist News Release.] See also https://www.nist.gov/system/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'.  Nist Planning Report 02-3], Executive Summary and Chapter 8.
 - [[[2]]] https://www.oracle.com/java/technologies/javase/codeconventions-introduction.html['Code Conventions for the Java Programming Language: 1. Introduction'. Sun Microsystems.]
 - [[[3]]] https://en.wikipedia.org/wiki/Software_maintenance['Software maintenance'. Wikipedia.]
 - [[[4]]] https://lore.kernel.org/git/7vps5xsbwp.fsf_-_@assigned-by-dhcp.cox.net/[Junio C Hamano. 'Automated bisect success story'.]
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] git-bisect-lk2009: update nist report link
  2023-01-10  9:32   ` [PATCH v2 2/2] git-bisect-lk2009: update nist report link Andrei Rybak
@ 2023-01-10 12:26     ` Jeff King
  0 siblings, 0 replies; 5+ messages in thread
From: Jeff King @ 2023-01-10 12:26 UTC (permalink / raw)
  To: Andrei Rybak; +Cc: git, Christian Couder

On Tue, Jan 10, 2023 at 10:32:51AM +0100, Andrei Rybak wrote:

> Commit d656218a83 (docs/bisect-lk2009: update nist report link,
> 2017-04-20) replaced a dead link to news release on nist.gov.  However,
> this might be confusing to the reader (like myself) because the article
> git-bisect-lk2009.txt quotes from the news release but the exact quote
> cannot be found in the full report.  In addition to that, the link added
> in 2017 is also dead in 2023.
> 
> Replace the reference to nist.gov with an version of the original NIST
> news release archived to the Wayback Machine.  Include also an updated
> link to a live version of the full report.

Both this and the other patch seem reasonable to me.

> I wasn't sure about inclusion of links to https://web.archive.org, but there is
> a single precedent already in "Documentation/gitcore-tutorial.txt".

I think it's a good match for this kind of link. The point is to cite a
historical artifact, and if archive.org is the only way to get the artifact,
then that's what we should do. Arguably it's what I should have done in
d656218a83 in the first place.

> --- a/Documentation/git-bisect-lk2009.txt
> +++ b/Documentation/git-bisect-lk2009.txt
> @@ -1347,7 +1347,7 @@ author to given a talk and for publishing this paper.
>  References
>  ----------
>  
> -- [[[1]]] https://www.nist.gov/sites/default/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'.  Nist Planning Report 02-3], see Executive Summary and Chapter 8.
> +- [[[1]]] https://web.archive.org/web/20091206032101/http://www.nist.gov/public_affairs/releases/n02-10.htm['Software Errors Cost U.S. Economy $59.5 Billion Annually'. Nist News Release.] See also https://www.nist.gov/system/files/documents/director/planning/report02-3.pdf['The Economic Impacts of Inadequate Infratructure for Software Testing'.  Nist Planning Report 02-3], Executive Summary and Chapter 8.

The link target given to archive.org is for http, not https. I guess it
doesn't really matter as they archived the same content back then, and
the actual browser connection to archive.org will be over https. And
yours is more historically accurate. ;)

-Peff

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-01-10 12:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10  8:38 [PATCH] git-bisect-lk2009: update java code conventions link Andrei Rybak
2023-01-10  9:32 ` [PATCH v2 0/2] update references in git-bisect-lk2009.txt Andrei Rybak
2023-01-10  9:32   ` [PATCH v2 1/2] git-bisect-lk2009: update java code conventions link Andrei Rybak
2023-01-10  9:32   ` [PATCH v2 2/2] git-bisect-lk2009: update nist report link Andrei Rybak
2023-01-10 12:26     ` Jeff King

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).