From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-1.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 90FEC1F852 for ; Mon, 19 Dec 2022 14:03:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (3072-bit key; secure) header.d=crustytoothpaste.net header.i=@crustytoothpaste.net header.b="xHO7vyp3"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231835AbiLSODb (ORCPT ); Mon, 19 Dec 2022 09:03:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231700AbiLSODZ (ORCPT ); Mon, 19 Dec 2022 09:03:25 -0500 Received: from ring.crustytoothpaste.net (ring.crustytoothpaste.net [IPv6:2600:3c04::f03c:92ff:fe9e:c6d8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B2BDFE6 for ; Mon, 19 Dec 2022 06:03:23 -0800 (PST) Received: from tapette.crustytoothpaste.net (unknown [IPv6:2001:470:b056:101:e59a:3ed0:5f5c:31f3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by ring.crustytoothpaste.net (Postfix) with ESMTPSA id BB3EA5A20E; Mon, 19 Dec 2022 14:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1671458602; bh=HLIHfMb/+fQBsgPRVp36DLdHgk+ZRqw/Go9xHoIeVKU=; h=Date:From:To:Cc:Subject:References:Content-Type: Content-Disposition:In-Reply-To:From:Reply-To:Subject:Date:To:CC: Resent-Date:Resent-From:Resent-To:Resent-Cc:In-Reply-To:References: Content-Type:Content-Disposition; b=xHO7vyp3VI8URfYN3wrYFC220QLqqlVzUF6FwJ3tmnowKyXHJTGiKQv0cOJXsQgfD ImB6lBK/xj+2KpQugkKAozHTjh0jFjW6frHXt0Xe4y9mTU8l0W3GX4B9bOeRzjIga/ 2FM7a/EApecJ2P9l6aqk18CqmAP0+hqRi18RVNLtkaFoKzs3kMz3K3LVumufSIh/Sd 8pqMwmVc5y+gvcLGSuH004pzMJ3ePG4Lid9xYMIRDnqyYpxLFS6GypE1pBGKUlQr08 PbP6aVzZEN2zZ90qlHJu+nx6IDvsf5MV1kizOoqDIWsR1QwxnZO3Mk+Jxb+2VgMAlX TJQd3fmZS5O7v1n+tUkG08OkqzBFjC3LR0CgCwGgWZ1ZLWX4UgXX6nfOsKtBaVW45Q ta/CHACXoToDMU4iz2geOM6hQB633pRWqAX0w0L5ExJLzkEMmX0+uKT98Ve0tjXVSE STk39YuFn0Fj/0vYvbzMIdPsADKzgOE8H9upqTTstzzroq2QkFL Date: Mon, 19 Dec 2022 14:03:21 +0000 From: "brian m. carlson" To: SZEDER =?utf-8?B?R8OhYm9y?= Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH] tests: make 'test_oid' print trailing newline Message-ID: Mail-Followup-To: "brian m. carlson" , SZEDER =?utf-8?B?R8OhYm9y?= , git@vger.kernel.org, Junio C Hamano References: <20221218162905.3508164-1-szeder.dev@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EGxfMnx6atw6yzxe" Content-Disposition: inline In-Reply-To: <20221218162905.3508164-1-szeder.dev@gmail.com> User-Agent: Mutt/2.2.9 (2022-11-12) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org --EGxfMnx6atw6yzxe Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-12-18 at 16:29:05, SZEDER G=C3=A1bor wrote: > Arguably we would be better off if 'test_oid' terminated its output > with a LF. So let's update 'test_oid' accordingly, update its tests > in t0000 to account for the extra character in those size tests, and > remove the now unnecessary 'echo $(...)' command substitutions around > 'test_oid' invocations as well. I don't recall that there was a particular reason for me to do it the way that it was, and if the commit message doesn't mention it, I think it's fine to replace it. Perhaps I intended to allow writing the binary form as well as the text form, in which case a newline would be undesirable, but I simply don't recall. All that to say, I think this patch is fine as it stands. --=20 brian m. carlson (he/him or they/them) Toronto, Ontario, CA --EGxfMnx6atw6yzxe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.2.40 (GNU/Linux) iHUEABYKAB0WIQQILOaKnbxl+4PRw5F8DEliiIeigQUCY6BvKQAKCRB8DEliiIei gYDCAQDhOu0YnS/UFha/ku91Mcp4MmqD0lyMPHwLfpae58C1PwEAxxIgq868BiIu rQ//lKvxtSF5aVatewZrMXCbjl55iwE= =khSD -----END PGP SIGNATURE----- --EGxfMnx6atw6yzxe--