From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 2F3271F61A for ; Wed, 14 Dec 2022 16:18:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238869AbiLNQSX (ORCPT ); Wed, 14 Dec 2022 11:18:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237959AbiLNQSW (ORCPT ); Wed, 14 Dec 2022 11:18:22 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98ED82714C for ; Wed, 14 Dec 2022 08:18:20 -0800 (PST) Received: (qmail 25878 invoked by uid 109); 14 Dec 2022 16:18:20 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 14 Dec 2022 16:18:20 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 19937 invoked by uid 111); 14 Dec 2022 16:18:19 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 14 Dec 2022 11:18:19 -0500 Authentication-Results: peff.net; auth=none Date: Wed, 14 Dec 2022 11:18:19 -0500 From: Jeff King To: git@vger.kernel.org Subject: [PATCH 0/5] minor ref-filter error-reporting bug-fixes Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org This series fixes a few small inconsistencies in the error-reporting from ref-filter's atom parsers. Mostly I noticed this while dealing with unused parameters in one of the parsers, which led to noticing a few other small bugs. And I hope the result is a little cleaner, as it should reduce the number of strings needing translation. [1/5]: ref-filter: reject arguments to %(HEAD) [2/5]: ref-filter: factor out "%(foo) does not take arguments" errors [3/5]: ref-filter: factor out "unrecognized %(foo) arg" errors [4/5]: ref-filter: truncate atom names in error messages [5/5]: ref-filter: convert email atom parser to use err_bad_arg() ref-filter.c | 44 +++++++++++++++++++++++++++++------------ t/t6300-for-each-ref.sh | 18 +++++++++++++++++ 2 files changed, 49 insertions(+), 13 deletions(-) -Peff