From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/9] more -Wunused-parameter fixes/annotations
Date: Tue, 13 Dec 2022 06:10:54 -0500 [thread overview]
Message-ID: <Y5hdvpbLpXySHFRz@coredump.intra.peff.net> (raw)
This was supposed to just be annotations, but after staring at a few of
the cases, I think we're better off removing the unused parameters. I've
floated those ones up to the top of the series.
[1/9]: ls-refs: use repository parameter to iterate refs
[2/9]: blob: drop unused parts of parse_blob_buffer()
[3/9]: list-objects: drop process_gitlink() function
[4/9]: ws: drop unused parameter from ws_blank_line()
[5/9]: xdiff: drop unused parameter in def_ff()
[6/9]: xdiff: mark unused parameter in xdl_call_hunk_func()
[7/9]: diff: mark unused parameters in callbacks
[8/9]: list-objects-filter: mark unused parameters in virtual functions
[9/9]: userdiff: mark unused parameter in internal callback
add-interactive.c | 2 +-
apply.c | 4 ++--
blob.c | 3 +--
blob.h | 3 +--
builtin/add.c | 2 +-
builtin/fast-export.c | 2 +-
builtin/merge-tree.c | 2 +-
builtin/merge.c | 2 +-
builtin/rerere.c | 2 +-
builtin/reset.c | 3 ++-
builtin/submodule--helper.c | 2 +-
cache.h | 2 +-
combine-diff.c | 2 +-
diff-lib.c | 2 +-
diff.c | 18 +++++++++---------
list-objects-filter.c | 30 +++++++++++++++---------------
list-objects.c | 33 +--------------------------------
ls-refs.c | 5 +++--
object.c | 5 ++---
range-diff.c | 12 ++++++++----
ref-filter.c | 5 +++--
refs.c | 9 +++++----
refs.h | 6 ++++--
revision.c | 25 +++++++++++++++----------
submodule.c | 2 +-
userdiff.c | 3 ++-
ws.c | 2 +-
wt-status.c | 4 ++--
xdiff/xdiffi.c | 2 +-
xdiff/xemit.c | 4 ++--
30 files changed, 90 insertions(+), 108 deletions(-)
-Peff
next reply other threads:[~2022-12-13 11:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 11:10 Jeff King [this message]
2022-12-13 11:11 ` [PATCH 1/9] ls-refs: use repository parameter to iterate refs Jeff King
2022-12-13 11:11 ` [PATCH 2/9] blob: drop unused parts of parse_blob_buffer() Jeff King
2022-12-13 11:12 ` [PATCH 3/9] list-objects: drop process_gitlink() function Jeff King
2022-12-13 11:12 ` [PATCH 4/9] ws: drop unused parameter from ws_blank_line() Jeff King
2022-12-13 11:13 ` [PATCH 5/9] xdiff: drop unused parameter in def_ff() Jeff King
2022-12-13 11:13 ` [PATCH 6/9] xdiff: mark unused parameter in xdl_call_hunk_func() Jeff King
2022-12-13 11:13 ` [PATCH 7/9] diff: mark unused parameters in callbacks Jeff King
2022-12-13 11:14 ` [PATCH 8/9] list-objects-filter: mark unused parameters in virtual functions Jeff King
2022-12-13 11:16 ` [PATCH 9/9] userdiff: mark unused parameter in internal callback Jeff King
2022-12-14 1:38 ` [PATCH 0/9] more -Wunused-parameter fixes/annotations Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5hdvpbLpXySHFRz@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).