From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id E86DB1F601 for ; Thu, 8 Dec 2022 06:36:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbiLHGgg (ORCPT ); Thu, 8 Dec 2022 01:36:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbiLHGgf (ORCPT ); Thu, 8 Dec 2022 01:36:35 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD9A19E45A for ; Wed, 7 Dec 2022 22:36:34 -0800 (PST) Received: (qmail 22751 invoked by uid 109); 8 Dec 2022 06:36:34 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 08 Dec 2022 06:36:34 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9577 invoked by uid 111); 8 Dec 2022 06:36:35 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 08 Dec 2022 01:36:35 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 8 Dec 2022 01:36:33 -0500 From: Jeff King To: Derrick Stolee Cc: Derrick Stolee via GitGitGadget , git@vger.kernel.org, gitster@pobox.com, me@ttaylorr.com, newren@gmail.com, avarab@gmail.com, mjcheetham@outlook.com, steadmon@google.com, chooglen@google.com, jonathantanmy@google.com, dyroneteng@gmail.com Subject: Re: [PATCH v3 10/11] bundle-uri: download bundles from an advertised list Message-ID: References: <69bf154bec63a22df8e5eac89f975625ce73c8ac.1670262639.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Dec 07, 2022 at 10:27:06AM -0500, Derrick Stolee wrote: > > The "uri" parameter in this function is unused. I'm not sure if that's > > indicative of a bug or missing feature (e.g., could it be the base for a > > relative url?), or if it's just a leftover from development. > > Thanks for your careful eye. This 'uri' is indeed not needed. I think it > was initially there for relative URIs, but the given 'list' is expected > to have that value initialized. I'll make it clear in the doc comment. That makes sense. I've queued a patch locally to remove it (since locally I build with -Wunused-parameters), which will eventually make its way to the list. > > If the latter, I'm happy to add it to my list of cleanups. > > > > There are a couple other unused parameters in this series, too, but they > > are all in virtual functions and must be kept. I'll add them to my list > > of annotations. > > Your UNUSED annotations exist in my tree, so I'll try my best to update > them in the next version. Sounds good (and again, I've queued something locally, but if you beat me to it, it's easy to drop mine). Note that your series hit 'next' (which is how I noticed it), so there usually would not be a "next version". Though we will rewind post-release, so there may still be an opportunity (I didn't follow the topic closely enough to know if you might want to re-roll for other reasons). -Peff