From: Taylor Blau <me@ttaylorr.com>
To: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <derrickstolee@github.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Victoria Dye <vdye@github.com>,
ZheNing Hu <adlternative@gmail.com>
Subject: Re: [PATCH] scalar: use verbose mode in clone
Date: Wed, 7 Dec 2022 17:10:30 -0500 [thread overview]
Message-ID: <Y5EPVpb511wk5Uw/@nand.local> (raw)
In-Reply-To: <pull.1441.git.1670436656379.gitgitgadget@gmail.com>
On Wed, Dec 07, 2022 at 06:10:56PM +0000, ZheNing Hu via GitGitGadget wrote:
> So add `[--verbose| -v]` to scalar clone, to enable
> fetch's output.
Seems reasonable.
> @@ -84,6 +84,11 @@ cloning. If the HEAD at the remote did not point at any branch when
> A sparse-checkout is initialized by default. This behavior can be
> turned off via `--full-clone`.
>
> +-v::
> +--verbose::
> + When scalar executes `git fetch`, `--quiet` is used by default to
> + suppress the output of fetch, use verbose mode for cancel this.
> +
This description may be exposing a few too many implementation details
for our liking. E.g., scalar happens to use `git fetch`, but it might
not always. That is probably academic, but a more practical reason to do
some hiding here might just be that it's unnecessary detail to expose in
our documentation.
Perhaps something like:
-v::
--verbose::
Enable more verbose output when cloning a repository.
Or something simple like that.
> List
> ~~~~
>
> diff --git a/scalar.c b/scalar.c
> index 6c52243cdf1..b1d4504d136 100644
> --- a/scalar.c
> +++ b/scalar.c
> @@ -404,7 +404,7 @@ void load_builtin_commands(const char *prefix, struct cmdnames *cmds)
> static int cmd_clone(int argc, const char **argv)
> {
> const char *branch = NULL;
> - int full_clone = 0, single_branch = 0;
> + int full_clone = 0, single_branch = 0, verbosity = 0;
> struct option clone_options[] = {
> OPT_STRING('b', "branch", &branch, N_("<branch>"),
> N_("branch to checkout after clone")),
> @@ -413,6 +413,7 @@ static int cmd_clone(int argc, const char **argv)
> OPT_BOOL(0, "single-branch", &single_branch,
> N_("only download metadata for the branch that will "
> "be checked out")),
> + OPT__VERBOSITY(&verbosity),
> OPT_END(),
> };
> const char * const clone_usage[] = {
Looking good.
> @@ -499,7 +500,9 @@ static int cmd_clone(int argc, const char **argv)
> if (set_recommended_config(0))
> return error(_("could not configure '%s'"), dir);
>
> - if ((res = run_git("fetch", "--quiet", "origin", NULL))) {
> + if ((res = run_git("fetch", "origin",
> + verbosity ? NULL : "--quiet",
> + NULL))) {
Hmmph. This and below are a little strange in that they will end up
calling:
run_git("fetch", "origin", NULL, NULL);
when running without `--verbose`. `run_git()` will still do the right
thing and stop reading its arguments after the first NULL that it sees.
So I doubt that it's a huge deal in practice, but felt worth calling out
nonetheless.
Is there an opportunity to easily test this new code?
Thanks,
Taylor
next prev parent reply other threads:[~2022-12-07 22:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 18:10 [PATCH] scalar: use verbose mode in clone ZheNing Hu via GitGitGadget
2022-12-07 22:10 ` Taylor Blau [this message]
2022-12-08 15:54 ` ZheNing Hu
2022-12-08 16:30 ` Derrick Stolee
2022-12-13 16:37 ` ZheNing Hu
2022-12-25 13:29 ` [PATCH v2] scalar: show progress if stderr refer to a terminal ZheNing Hu via GitGitGadget
2023-01-05 19:19 ` Derrick Stolee
2023-01-06 12:30 ` Junio C Hamano
2023-01-11 11:59 ` ZheNing Hu
2023-01-11 13:14 ` [PATCH v3] " ZheNing Hu via GitGitGadget
2023-01-11 14:55 ` Derrick Stolee
2023-01-13 19:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5EPVpb511wk5Uw/@nand.local \
--to=me@ttaylorr.com \
--cc=adlternative@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).