From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Rose via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Jeff Hostetler <git@jeffhostetler.com>,
Rose <83477269+AtariDreams@users.noreply.github.com>,
Seija <doremylover123@gmail.com>
Subject: Re: [PATCH v6] revision: use calloc instead of malloc where possible
Date: Wed, 7 Dec 2022 15:44:33 +0700 [thread overview]
Message-ID: <Y5BScRmR1fY/SQCq@debian.me> (raw)
In-Reply-To: <pull.1390.v6.git.git.1670356394394.gitgitgadget@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Tue, Dec 06, 2022 at 07:53:14PM +0000, Rose via GitGitGadget wrote:
> From: Seija <doremylover123@gmail.com>
>
> We can avoid having to call memset by calling calloc
Who are "we"?
Please avoid using first-person pronouns (I and we), since these are
ambiguous in context of many entities (individuals/companies)
participating in development. Instead, write in imperative mood and
passive voice, e.g. "Avoid the need to call memset by allocating with
calloc() instead of malloc().".
Even then, what are justifications of malloc() -> calloc() conversion
other than the described above?
>
> Signed-off-by: Seija doremylover123@gmail.com
The SoB doesn't look OK. It should have been
"Signed-off-by: Your Real Name <yourname@what.domain>".
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-12-07 8:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 14:48 [PATCH] maintenance: use xcalloc instead of xmalloc where possible Rose via GitGitGadget
2022-12-05 15:01 ` Jeff Hostetler
2022-12-05 15:33 ` [PATCH v2] " Rose via GitGitGadget
2022-12-05 16:01 ` [PATCH v3] " Rose via GitGitGadget
2022-12-05 16:12 ` [PATCH v4] maintenance: use calloc instead of malloc " Rose via GitGitGadget
2022-12-06 5:03 ` Junio C Hamano
2022-12-06 17:38 ` [PATCH v5] revision: " Rose via GitGitGadget
2022-12-06 19:44 ` Ævar Arnfjörð Bjarmason
2022-12-06 19:53 ` [PATCH v6] " Rose via GitGitGadget
2022-12-07 8:44 ` Bagas Sanjaya [this message]
2024-12-18 0:30 ` [PATCH v7] " AreaZR via GitGitGadget
2024-12-18 0:48 ` [PATCH v8] git: " AreaZR via GitGitGadget
2024-12-18 0:58 ` [PATCH v9] " AreaZR via GitGitGadget
2024-12-18 1:26 ` [PATCH v10] git: use calloc instead of malloc + memset " AreaZR via GitGitGadget
2024-12-18 15:39 ` Junio C Hamano
2024-12-18 16:48 ` [PATCH v11] " AreaZR via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5BScRmR1fY/SQCq@debian.me \
--to=bagasdotme@gmail.com \
--cc=83477269+AtariDreams@users.noreply.github.com \
--cc=doremylover123@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).