mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <>
To: "Ævar Arnfjörð Bjarmason" <>
Cc: Rose via GitGitGadget <>,, Seija <>
Subject: Re: [PATCH] maintenance: compare output of pthread functions for inequality with 0
Date: Fri, 2 Dec 2022 20:55:21 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On 2022-12-02 at 18:10:57, Ævar Arnfjörð Bjarmason wrote:
> But (and especially if you're interested) we really should follow-up
> here and fix the "error()" etc. part of this. After this we have cases
> in-tree where we on failure:
>  * Call die_errno() (good)
>  * Call die(), error() etc., but with a manual strerror() argument,
>    these should just use the *_errno() helper.
>  * Don't report on the errno at all, e.g. in this case shown here.
> It seems to me that all of these should be using die_errno(),
> error_errno() etc.

Actually, I don't think that's correct.

> Or maybe it's the other way around, and we should not rely on the global
> "errno", but always capture the return value, and give that to
> strerror() (or set "errno = ret", and call {die,error,warning}_errno()).

Yeah, I think we need to do this.  That's because unlike most other
functions, the pthread functions _don't_ set errno, and instead return
the error value.  That's why on a typical Unix system, we would have
never failed before this patch: because errno values are always
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  parent reply	other threads:[~2022-12-02 20:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 17:02 [PATCH] maintenance: compare output of pthread functions for inequality with 0 Rose via GitGitGadget
2022-12-02 18:05 ` Jeff Hostetler
2022-12-02 18:10 ` Ævar Arnfjörð Bjarmason
2022-12-02 18:44   ` Jeff Hostetler
2022-12-02 20:55   ` brian m. carlson [this message]
2022-12-02 22:46     ` Ævar Arnfjörð Bjarmason
2022-12-03  0:26       ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).