From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 2FC941F4C1 for ; Tue, 29 Nov 2022 10:03:05 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YWoLx/Gh"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232084AbiK2KDC (ORCPT ); Tue, 29 Nov 2022 05:03:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiK2KC6 (ORCPT ); Tue, 29 Nov 2022 05:02:58 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 683E85B590 for ; Tue, 29 Nov 2022 02:02:56 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id r26so16941714edc.10 for ; Tue, 29 Nov 2022 02:02:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=65KHMz7WYrnqPXM8GBSDMVAdlyP6ZXLoeEKZDqI114w=; b=YWoLx/GhGWmQSfu8WFt/PnmtIKp4bb1MZ3RivpV5oxHYgOtcjE/wVyHIutRs+VDCdw pBnXbYM2MOuYuXoRWWCSOyTtj9wdG5C6qUdKW0AyJSlXIqKPVoPXcs31PHre2wL0if9U pank7sDMP7K2T2i9UNm7USklhpuQD6gFS2nTt5XydZjk5Mzi7cWT5slGEeY9yiwOnmtM FHJ2EsL0NJkhl4aIfho2lMrbcF7Qr9TK/VuSmcgmJFL2MPWHG2lhiy7b4V1L3i2TYF7d uDQVNZELhRE4rJcd2/ZvV3OmTZUK2ybFCivh2pHa+wvFLCeTq75U2sj8rejkHiGzIK2d dhHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=65KHMz7WYrnqPXM8GBSDMVAdlyP6ZXLoeEKZDqI114w=; b=Am2yhvNrDXt8NpkWF0UN82jhrJm7OltIjW98H1AFG8a/sHMKY6LskPpG9/qDpfVew+ 6Pjn77nQek4gmeHiY2PTRg8/hKoqQH1P5npad8d2jTeCGfZE6jZLnwV2Zdm9sgSFrTC6 uVZv30ISnY97kINP9wYrvj4fMI7hUx3i9eK7GxNuj0dvFwrKAqIvPI8O08KLFg4z2sDe IFBcf0va6rS/sOEKERdkpy6tMTNCivEqvPCaBtH3TWMO13MP59Dybg/1MMpnaH0+1ulz fuSvqwjnFeb3Jgoa6C37NdtvQDB4cn3l/Sq0GbBR79WhBrvkt10fE5/kivqHpeEfxVsI yigw== X-Gm-Message-State: ANoB5pmi6LPdmG4b/1DtcWoNgCPXDEObwrrmcilZHc71nHj3x2eJRtIC hOxRS2IJxgHHvcZRefNKPJntBy7TAo4= X-Google-Smtp-Source: AA0mqf5Wcu6vED1LtBNe0Lec3ttaTXQ6uZEYcajWSiGyay702C7DnHOal7wfGWzl17lhLIRMhjA2Pg== X-Received: by 2002:aa7:d3cb:0:b0:461:8d98:3d6d with SMTP id o11-20020aa7d3cb000000b004618d983d6dmr37203373edr.116.1669716174619; Tue, 29 Nov 2022 02:02:54 -0800 (PST) Received: from orome (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id c2-20020a17090618a200b007bd15e582a3sm4649406ejf.181.2022.11.29.02.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 02:02:53 -0800 (PST) Date: Tue, 29 Nov 2022 11:02:52 +0100 From: Thierry Reding To: Taylor Blau Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH v3] am: Allow passing --no-verify flag Message-ID: References: <20221128174825.1510407-1-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UrQ7TDqUuddfI462" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org --UrQ7TDqUuddfI462 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 28, 2022 at 06:07:38PM -0500, Taylor Blau wrote: > Hi Thierry, >=20 > This is looking pretty good. Thanks for pushing out a couple of new > rounds. I took a look at the discussion and have some thoughts below, > but they are minor. >=20 > This will likely not be in the upcoming v2.39.0, since Junio has already > cut and pushed the first release candidate tag. But you should feel free > to keep working on it in the meantime and we can revisit it post-2.39. That's fine. No rush. I've had local workarounds for this for a very long time, so I can be patient for a little longer. =3D) > On Mon, Nov 28, 2022 at 06:48:25PM +0100, Thierry Reding wrote: > > diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt > > index 326276e51ce5..0c1dfb3c98b4 100644 > > --- a/Documentation/git-am.txt > > +++ b/Documentation/git-am.txt > > @@ -9,7 +9,7 @@ git-am - Apply a series of patches from a mailbox > > SYNOPSIS > > -------- > > [verse] > > -'git am' [--signoff] [--keep] [--[no-]keep-cr] [--[no-]utf8] > > +'git am' [--signoff] [--keep] [--[no-]keep-cr] [--[no-]utf8] [--no-ver= ify] >=20 > Spelling this as "[--no-verify]" and not "[--[no-]verify]" is right, > since the option itself is called "--no-verify" (and thus has the > OPT_NONEG flag bit set), and "--verify" does not exist. Good. >=20 > > [--[no-]3way] [--interactive] [--committer-date-is-author-date] > > [--ignore-date] [--ignore-space-change | --ignore-whitespace] > > [--whitespace=3D