From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Christian Göttsche" <cgzones@googlemail.com>, git@vger.kernel.org
Subject: Re: [PATCH] setup: avoid unconditional open with write flags
Date: Mon, 5 Dec 2022 20:38:37 -0500 [thread overview]
Message-ID: <Y46dHWVaU00WFL+f@coredump.intra.peff.net> (raw)
In-Reply-To: <Y45tGLaJwg3Lt5uJ@tapette.crustytoothpaste.net>
On Mon, Dec 05, 2022 at 10:13:44PM +0000, brian m. carlson wrote:
> _However_, I will say that `git status` is not a read-only command
> because it can write the index, and we aren't, in general, going to be
> able to promise that any portion of Git will work with only O_RDONLY
> file descriptors. I suspect such a sandbox is going to result in a
> highly broken Git in general, and so it wouldn't be a good idea.
I wonder if "git status" might work OK in a sandbox, because it should
quietly skip the on-disk index refresh if something fails. That is, it's
supposed to work in a read-only repository. As long as the sandbox just
returns an error when opening the lockfile (and not, say, killing the
process), it would look the same to Git.
-Peff
next prev parent reply other threads:[~2022-12-06 1:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 19:00 [PATCH] setup: avoid unconditional open with write flags Christian Göttsche
2022-12-05 22:13 ` brian m. carlson
2022-12-06 1:38 ` Jeff King [this message]
2022-12-06 16:15 ` Christian Göttsche
2022-12-05 22:59 ` Taylor Blau
2022-12-06 0:10 ` Junio C Hamano
2022-12-06 0:31 ` Taylor Blau
2022-12-06 0:40 ` Junio C Hamano
2022-12-06 19:47 ` René Scharfe
2022-12-06 23:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y46dHWVaU00WFL+f@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=cgzones@googlemail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).