From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 8B2C31F910 for ; Mon, 21 Nov 2022 19:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231174AbiKUT2O (ORCPT ); Mon, 21 Nov 2022 14:28:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbiKUT2L (ORCPT ); Mon, 21 Nov 2022 14:28:11 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48BC42250C for ; Mon, 21 Nov 2022 11:28:10 -0800 (PST) Received: (qmail 12563 invoked by uid 109); 21 Nov 2022 19:28:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 21 Nov 2022 19:28:09 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 26695 invoked by uid 111); 21 Nov 2022 19:28:09 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 21 Nov 2022 14:28:09 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 21 Nov 2022 14:28:08 -0500 From: Jeff King To: Eric Sunshine Cc: Eric Wong , Eric Sunshine via GitGitGadget , Git List , Elijah Newren , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Fabian Stelzer , Johannes Schindelin Subject: Re: [PATCH 06/18] chainlint.pl: validate test scripts in parallel Message-ID: References: <62fc652eb47a4df83d88a197e376f28dbbab3b52.1661992197.git.gitgitgadget@gmail.com> <20220906223537.M956576@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Nov 21, 2022 at 02:00:41PM -0500, Eric Sunshine wrote: > On Mon, Nov 21, 2022 at 1:52 PM Jeff King wrote: > > On Mon, Nov 21, 2022 at 01:47:42PM -0500, Eric Sunshine wrote: > > > I think Ævar's use-case for `make` parallelization was to speed up > > > git-bisect runs. But thinking about it now, the likelihood of "lint" > > > problems cropping up during a git-bisect run is effectively nil, in > > > which case setting GIT_TEST_CHAIN_LINT=1 should be a perfectly > > > appropriate way to take linting out of the equation when bisecting. > > > > Yes. It's also dumb to run a straight "make test" while bisecting in the > > first place, because you are going to run a zillion tests that aren't > > relevant to your bisection. Bisecting on "cd t && ./test-that-fails" is > > faster, at which point you're only running the one lint process (and if > > it really bothers you, you can disable chain lint as you suggest). > > I think I misspoke. Dredging up old memories, I think Ævar's use-case > is that he now runs: > > git rebase -i --exec 'make test' ... > > in order to ensure that the entire test suite passes for _every_ patch > in a series. (This is due to him having missed a runtime breakage by > only running "make test" after the final patch in a series was > applied, when the breakage was only temporary -- added by one patch, > but resolved by some other later patch.) Yeah, I do that sometimes, too, especially when heavy refactoring is involved. > Even so, GIT_TEST_CHAIN_LINT=0 should be appropriate here too. Agreed. But also, my original point stands. If you are running 10 CPU minutes of tests, then a few CPU seconds of linting is not really that important. -Peff