From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 5386D1F910 for ; Mon, 21 Nov 2022 19:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbiKUTFA (ORCPT ); Mon, 21 Nov 2022 14:05:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiKUTE7 (ORCPT ); Mon, 21 Nov 2022 14:04:59 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AF17450B5 for ; Mon, 21 Nov 2022 11:04:57 -0800 (PST) Received: (qmail 12402 invoked by uid 109); 21 Nov 2022 19:04:56 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 21 Nov 2022 19:04:56 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 26459 invoked by uid 111); 21 Nov 2022 19:04:56 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 21 Nov 2022 14:04:56 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 21 Nov 2022 14:04:55 -0500 From: Jeff King To: Teng Long Cc: avarab@gmail.com, derrickstolee@github.com, git@vger.kernel.org, gitster@pobox.com, me@ttaylorr.com, tenglong.tl@alibaba-inc.com Subject: Re: [PATCH v4 0/4] pack-bitmap.c: avoid exposing absolute paths Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Nov 21, 2022 at 08:16:11PM +0800, Teng Long wrote: > Diff since v3: > > I picked Peff's two new constructive patches[1] which I think are meaningful. > Peff also mentioned whether to design a "GIT_TRACE2_BITMAP" ENV to help > debugging bitmap, and I think it's very interesting but maybe it's a bigger > scale on current patchset, so I prefer to do it in another series. I think the first two are already in 'next', so they aren't eligible for re-roll, though from the range diff it looks like those changes are already there? -Peff