From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id E3F041F910 for ; Mon, 21 Nov 2022 18:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230444AbiKUSEq (ORCPT ); Mon, 21 Nov 2022 13:04:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiKUSEp (ORCPT ); Mon, 21 Nov 2022 13:04:45 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 601B95C776 for ; Mon, 21 Nov 2022 10:04:43 -0800 (PST) Received: (qmail 12277 invoked by uid 109); 21 Nov 2022 18:04:43 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 21 Nov 2022 18:04:43 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 25945 invoked by uid 111); 21 Nov 2022 18:04:43 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 21 Nov 2022 13:04:43 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 21 Nov 2022 13:04:42 -0500 From: Jeff King To: Eric Sunshine Cc: Eric Wong , Eric Sunshine via GitGitGadget , Git List , Elijah Newren , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Fabian Stelzer , Johannes Schindelin Subject: Re: [PATCH 06/18] chainlint.pl: validate test scripts in parallel Message-ID: References: <62fc652eb47a4df83d88a197e376f28dbbab3b52.1661992197.git.gitgitgadget@gmail.com> <20220906223537.M956576@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Nov 20, 2022 at 11:02:54PM -0500, Eric Sunshine wrote: > > And if we did cache the results and avoid extra invocations via "make", > > then we'd want all the parallelism to move to there anyway. > > > > Maybe that gives you more food for thought about whether perl's "use > > threads" is worth having. > > I'm not especially happy about the significant overhead of "ithreads"; > on my (old) machine, although it does improve perceived time > significantly, it eats up quite a bit of additional user-time. As > such, I would not be unhappy to see "ithreads" go away, especially > since fast linting on Windows seems unattainable (at least with Perl). > > Overall, I think Ævar's plan to parallelize linting via "make" is > probably the way to go. TBH, I think just running the linter once per test script when the script is run would be sufficient. That is one extra process per script, but they are already shell scripts running a bunch of processes. You get parallelism for free because you're already running the tests in parallel. You lose out on "don't bother linting because the file hasn't changed", but I'm not sure that's really worth the extra complexity overall. -Peff