From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6D4621F910 for ; Sat, 19 Nov 2022 02:56:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="5zpwY2Bx"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230077AbiKSC42 (ORCPT ); Fri, 18 Nov 2022 21:56:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbiKSC40 (ORCPT ); Fri, 18 Nov 2022 21:56:26 -0500 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C6BF976C1 for ; Fri, 18 Nov 2022 18:56:25 -0800 (PST) Received: by mail-io1-xd31.google.com with SMTP id 11so5238310iou.0 for ; Fri, 18 Nov 2022 18:56:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n2dnJduIE5k4Bo6wPq5xfV0sgy4U7S00/ofLqsSq0XY=; b=5zpwY2BxeWpONURFhEmb0uct7ih+vwWaow2aOq1Mn/ZDUqLbCcpHYuE+oJsXRVzKZm NaUZ2l94bRS3GoAPnBYyU0/RDXt3fYiI7AuaW+1R22L22GA3tt4klBuOnm2o2OqA+3m+ qG6riNMzVdBliTQ1/XgReH6MD2ycP87zPVgyPsDlPobf7sthqiXa5XGN5q+Z8Hu8WvUE /GJTMnsHllBAbXII+RM5vuBdQnL272/nxjSdZFzfvTGAFxTrJJ74lhntQ3VdvQmXObg7 vN667rOS36RrEAtwB16BDFSZ4t3qKDwMF2k2vgwvfHgj4RG9AM5apQuUoOmJz3GD27yD Psqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n2dnJduIE5k4Bo6wPq5xfV0sgy4U7S00/ofLqsSq0XY=; b=tAt0+CNISGCCzNqVYQRCHfLs4c+PO1XI7GDff6e8DjpxzyyT0lzhRZ5I1FtBzooodt I+VEnNiRpVHd+hBvZoAkBiN85NcCD5w1+fL0ClzsGzP8R26SE0w8W9a1sm10F0cMOwXy qJZkn8iUrK+rGzZZIpyhvwgDF9GJZDA52Zl9zw0RNPEiwTSQhBHXhnrsMHM/o3Esn4+i wJIAIg5ECF5RNf7fwhmhhkA7m9vyPnLbMEp6TmC0j1j7rc8UhhwkiJH0/uCICBRMBtb7 wMrO5Tskmjhj4OMSxNz4eAuv19HuDK1bGYwM+p8qp8/FwIi0tieiN34GgK3SBeuwdv7z shkA== X-Gm-Message-State: ANoB5pmoRhjcgNGVgU4WAYgtl9zT9PZVhuKsSnSsvkrSa3sC6YpcBwdJ VsEIEw3omiAgXSeHAWUfOM+Gjw== X-Google-Smtp-Source: AA0mqf62GtuwMZMexJcoV958RU8F4WH0ogq4dfH2luDOKKZuFGYT3j1WoZIX/J0kjs5NZwnGt9JNyA== X-Received: by 2002:a02:a04e:0:b0:375:b099:e48e with SMTP id f14-20020a02a04e000000b00375b099e48emr4051519jah.319.1668826584538; Fri, 18 Nov 2022 18:56:24 -0800 (PST) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id q5-20020a5d8505000000b006bbddd49984sm1881799ion.9.2022.11.18.18.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 18:56:23 -0800 (PST) Date: Fri, 18 Nov 2022 21:56:22 -0500 From: Taylor Blau To: Junio C Hamano Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Johannes Schindelin , Johannes Schindelin via GitGitGadget , git@vger.kernel.org, =?utf-8?B?UmVuw6k=?= Scharfe , Eric Sunshine Subject: Re: [PATCH v3 2/2] tests(mingw): avoid very slow `mingw_test_cmp` Message-ID: References: <221114.86tu31lnwr.gmgdl@evledraar.gmail.com> <221114.86pmdplbs5.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 18, 2022 at 03:19:55PM -0800, Junio C Hamano wrote: > Well "! test_cmp" is wrong anyway, because it _expects_ two files > are the same and gives more detailed diagnosis when they differ by > giving "diff" output. > > If you expect them to be different, "! test_cmp" would give > "detailed diagnosis" in the wrong case, i.e. the outcome is what we > expect. I agree that "! test_cmp foo bar" will give output about how "foo" is different from "bar" (and halt the test only when the two have the same contents). > So the caller must do "test_cmp !" whether the underlying > implementation of test_cmp uses "diff -u" or "diff --no-index". But this confuses me. "git grep 'test_cmp !'" turns up no results, and furthermore, test_cmp() itself begins with: test "$#" -ne 2 && BUG "2 param" So I am not sure what you are referring to. Thanks, Taylor