From: Thierry Reding <thierry.reding@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] am: Allow passing --no-verify flag
Date: Sat, 19 Nov 2022 01:49:08 +0100 [thread overview]
Message-ID: <Y3goBHxEd8xUE4Bc@orome> (raw)
In-Reply-To: <Y3fNQ9ysAeOsyOSQ@nand.local>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
On Fri, Nov 18, 2022 at 01:21:55PM -0500, Taylor Blau wrote:
> On Fri, Nov 18, 2022 at 02:27:43PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The git-am --no-verify flag is analogous to the same flag passed to
> > git-commit. It bypasses the pre-applypatch and applypatch-msg hooks
> > if they are enabled.
>
> The patch below looks reasonable to me. Is there a way that we could
> test this easily? It looks trivially correct to my eyes, but I want to
> avoid the possibility of regressing here in the future.
Yeah, turns out this can be pretty easily checked. I'll resend a v2 with
the test included.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-11-19 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 13:27 [PATCH] am: Allow passing --no-verify flag Thierry Reding
2022-11-18 18:21 ` Taylor Blau
2022-11-19 0:49 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3goBHxEd8xUE4Bc@orome \
--to=thierry.reding@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).