From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 9081F1F910 for ; Fri, 18 Nov 2022 18:42:52 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="yRulRlEq"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241934AbiKRSmv (ORCPT ); Fri, 18 Nov 2022 13:42:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234391AbiKRSmu (ORCPT ); Fri, 18 Nov 2022 13:42:50 -0500 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FD5667128 for ; Fri, 18 Nov 2022 10:42:49 -0800 (PST) Received: by mail-io1-xd2a.google.com with SMTP id r81so4485637iod.2 for ; Fri, 18 Nov 2022 10:42:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=naUu/AfJY5y4FYH/7np1horclTUTnpFxNaP0AzCk8zA=; b=yRulRlEqfpPYIhI4qD3NGZEAu/bo3PiyjkP9rg9x2dwvKER0aTBQnOkh7hgHBFSXRk riwu0uCjEq/ATyAbNgBRtcIBGNQC3CQvdH9x5nCsWhY8yBPV3MWtvN204UJenmVcIsOi 6NXET5Xk4PgGV4N8cAOUMeGIh7c4BCWz4gukbMLsVRXYVWeVhXzaFzgDgCWjwQ9llC2y 7UgpPg46N1tHDAkihZtKIOkT52zaEZ61rCyN8FK04gVhJkgyOJZt2I1AIzTMepXzMnua ZDkI+iwiD38mYd+EjYR6/svmybc3HymS4H2Rv864mPByVE3PZ2gM5UfUF9Z0VoU4QWMs WfTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=naUu/AfJY5y4FYH/7np1horclTUTnpFxNaP0AzCk8zA=; b=SpMJO3TOATssoV5lR0wQtpJK2eyeoX6xOah2O3Xcr/0CviVD9MD0s4Cz9OoTB8+yJ3 EIk3dkl/2x2mwA+RMVfhko8r+pJ8fMxl/rODQr8GbQByW4mCs2pCB0iicMRODshFxAJj QKdgimiad3TIzgk+80JQ+2RlFTmY+4I0P7SRugzWn/685somZS8VTVJDcwxMU2S5fNNk GybY7R7J1bWW6tFhAJEgdlzv9gb9he0BsHox2XGG08ogBmhplFxlfQWEDdSYJC6nEZlC Qw3IxiNIDwXTNENNwTXT0ZAAWN1GuK/MncS4jLtf+S/FWVbc8NciS1Ec9GRqSgucl6+C SmQA== X-Gm-Message-State: ANoB5pm2fMMifk5L3KnguTImjv7pw5wmm9c0Sxc6muMMWdvtbef40b3g 7E+NR1TLWQ6jlr7bqf7ShQY6fg== X-Google-Smtp-Source: AA0mqf4Kp4nQAEl0aR0xbIrebZckFNgqK7SnmJbjTKGTBA4TwR3DyVaxrrZE8omII2MdgtC8to4TMQ== X-Received: by 2002:a02:2122:0:b0:375:13ba:925 with SMTP id e34-20020a022122000000b0037513ba0925mr3652766jaa.207.1668796968815; Fri, 18 Nov 2022 10:42:48 -0800 (PST) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id q5-20020a5d8505000000b006bbddd49984sm1534773ion.9.2022.11.18.10.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 10:42:48 -0800 (PST) Date: Fri, 18 Nov 2022 13:42:47 -0500 From: Taylor Blau To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH 12/12] builtin/*: remove or amend "USE_THE_INDEX_COMPATIBILITY_MACROS" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 18, 2022 at 12:31:06PM +0100, Ævar Arnfjörð Bjarmason wrote: > Follow-up the preceding commit and change > "USE_THE_INDEX_COMPATIBILITY_MACROS" to the more narrow > "USE_THE_INDEX_VARIABLE" in cases where we still use "the_index". > > Then remove "USE_THE_INDEX_VARIABLE" entirely in the few cases where > we don't require any compatibility macros or variables anymore. Could this get squashed into the previous commit? IOW, is there any reason to keep them separate? Thanks, Taylor