From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id EAA3C1F910 for ; Fri, 18 Nov 2022 18:41:54 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="z9z3sOFO"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242067AbiKRSlx (ORCPT ); Fri, 18 Nov 2022 13:41:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234391AbiKRSlv (ORCPT ); Fri, 18 Nov 2022 13:41:51 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7260B67128 for ; Fri, 18 Nov 2022 10:41:50 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id 11so4516395iou.0 for ; Fri, 18 Nov 2022 10:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=oiRHmMNP1Da+wFF6lcPADrSet0XXZm4k/o6O+4N4xUc=; b=z9z3sOFO7RFdTPlwzbtBgRTLEDqIysbfXBu7C1qYCj/pnhDRFn6AafiRfnlbLstnqT eMkd6GLPbo7TSQagsJ96TGHRzeqny3U+OxxBMA+N214BYJTYC1Av7jg6BNnHBXJka1Xt BbRY74Bf4UsbuenXO/aikWAREDyD+6Um1DzhyJRfzcDrqBuaxtEio0FVaGEveKxET79p v3lcRsq6sUxM+meo8RoHp6pAqFCynQ7wMvt2aNYE7p6PhB9XbTx40Ys1U8h9V///Y+Oj FPs1wPnFD62xF1j/eqUqQVdMz0NThmR/hyNBs7hJhuJdFbF+XGWxupCAMe4T7HldJUhX hTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oiRHmMNP1Da+wFF6lcPADrSet0XXZm4k/o6O+4N4xUc=; b=6Sw1BqL7cjQT3gTtlGIV+YocDDf2fDJhVlMJsECiLPh7TkGihu/5gGkH/ts/Zjj/hC 57keXauBpoA5cPg4AemB4D1V9keVJN0yh/0CUCwkIXm7cemAcFgao464Ue6LWRW+mCwP kx/uXaMxKE6WgLC8/JcCmtHY76cPjDhh2VObwKNEhU27AKB0a638zjUfK9OX0eLGaRVl OIr9RhGv1Farv4bqBNYSWXYveALVUcx+H3+2mQ5ooJ5S7aOGHUEZNvsCgmhbHQdlnog2 dg38FMf3Oc+wEYc7RUXooZJqIAph0Jdx3RRvYfKqAoC1ecNqORc3czHN4do/ru2zy4nq WsfA== X-Gm-Message-State: ANoB5pk7bY6rZ+Mf5Dqo+P7SDqjh0+dtPHBKRXbecBvjhF3F5/sDTxCJ yrsZODxFe0amWkkepAQbslKB146Ot5FVPw== X-Google-Smtp-Source: AA0mqf49TDMKdTFQyueXo+RfvgAtsBkuGVj/EjM9JRmW8K92kLuqnmQtXfSaRXEphARpAIsxrPm80Q== X-Received: by 2002:a02:c492:0:b0:375:c128:72a6 with SMTP id t18-20020a02c492000000b00375c12872a6mr3785124jam.151.1668796909750; Fri, 18 Nov 2022 10:41:49 -0800 (PST) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id o12-20020a92c04c000000b002eb1137a774sm1442342ilf.59.2022.11.18.10.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 10:41:49 -0800 (PST) Date: Fri, 18 Nov 2022 13:41:48 -0500 From: Taylor Blau To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH 10/12] cache.h & test-tool.h: add & use "USE_THE_INDEX_VARIABLE" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 18, 2022 at 12:31:04PM +0100, Ævar Arnfjörð Bjarmason wrote: > In a preceding commit we fully applied the > "index-compatibility.pending.cocci" rule to "t/helper/*". Let's now > stop defining "USE_THE_INDEX_COMPATIBILITY_MACROS" in test-tool.h > itself, and instead instead move the define to the individual test > helpers that need it. This mirrors how we do the same thing in the > "builtin/" directory. > > We could start using "USE_THE_INDEX_COMPATIBILITY_MACROS", but let's > instead introduce a narrow version of it named > "USE_THE_INDEX_VARIABLE". As the name suggests this doesn't give us > any of the compatibility macros, but only "the_index" variable. > > Eventually we'll move other outstanding users of > "USE_THE_INDEX_COMPATIBILITY_MACROS" over to using this more narrow > and descriptive define. The above two paragraphs look like they belong in the previous commit, no? Otherwise the rest of the changes here look reasonable. Thanks, Taylor