From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 81A651F910 for ; Wed, 16 Nov 2022 02:09:25 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="LIiXHjIH"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbiKPCJX (ORCPT ); Tue, 15 Nov 2022 21:09:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231465AbiKPCJW (ORCPT ); Tue, 15 Nov 2022 21:09:22 -0500 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ED955F8E for ; Tue, 15 Nov 2022 18:09:21 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id b2so12186435iof.12 for ; Tue, 15 Nov 2022 18:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0XiuaCjsXH8KKr5LWNqTZlcKN4zjSmvDK31n9Dfw//8=; b=LIiXHjIH3E0SNQciQRrQuuM6Ria3+2SbtafPbje/TRVGsgG/klzTgA4xMF9B94IWps 6a84a530Wg4HnW3WztXvMUlkdCr5LunJqscL6jndzCoEs3/4ywjaDTUdHLf+BQggIoMP iTd2vyoASzSWa+xSLUmKl91v07Cxv5Rb+Xf0M/5AZ05dKq1xiyilSWuDXqX9H2pSQOCs wjNdHPEDXMCFWuXNEQ0mioflMmcBt+tEBzmZ4tTL+/Bk6r3GLn+cCVq+nWJVx6oKyaIU +9Im8R2AO3A6GB8tIdd6UXRHuZPH4sTE5OpB0wWJZFSGlxIbOO0/0aOzdsvc2+VoQjNO 5D1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0XiuaCjsXH8KKr5LWNqTZlcKN4zjSmvDK31n9Dfw//8=; b=nQvpvEt5Qa1TrszlXZdWjARAgRDl6BKA2GDsuwLkRD3qugd5BQvFkPT/KAx+8m8HlI HaIF1YnN9sktcSL18vnBy4aetXgSrAFyrKSDk9sWqCaWNi2RkjJToGuCizAQIDNPxblx 5nwo4diCBZ9uwsU2b95siJl5k1foc7o7a3PS3v6kYLU98npS8aRE3KScOgkPCaJunjUO vBFwzeAtHhLFgpkl6xsZKd9jfvxkIAQesNx+zjzYZP/x1lAhfIFe4uK8UKObVnj4unEY dTmnAB83yCqbTedy9F/c/2Dm8/LU7CN8PcTDhg9Fwlr+0JpHBLh+bKeIPOrITGTUjY/z r2Iw== X-Gm-Message-State: ANoB5pkIxAjNS+2MV96wBuN8eXQ/4cNUJS2W4ap95j3g95U39wPN2aWD kUXCzE67MvnD1qLtTnyz/Fk3Nw== X-Google-Smtp-Source: AA0mqf559cpjLGV2HPGPvsnYt9KprdLoFrLnBHHC7F5lA703emOePjhYaUKTs9sFimMdLKgkFKVNTA== X-Received: by 2002:a6b:ca07:0:b0:6a1:2062:9855 with SMTP id a7-20020a6bca07000000b006a120629855mr9225647iog.214.1668564560992; Tue, 15 Nov 2022 18:09:20 -0800 (PST) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id c12-20020a02330c000000b00363a4fcd3a8sm5149553jae.5.2022.11.15.18.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 18:09:20 -0800 (PST) Date: Tue, 15 Nov 2022 21:09:19 -0500 From: Taylor Blau To: Johannes Schindelin via GitGitGadget Cc: git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH] range-diff: support reading mbox files Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Nov 15, 2022 at 06:20:05PM +0000, Johannes Schindelin via GitGitGadget wrote: > Let's offer a way to read those patches from pre-prepared MBox files > instead when an argument "mbox:" is passed instead of a commit > range. Very cool. Thanks for working on this. I don't have time to review the whole parser right now (and I agree that it would be nice to see it hook into the existing stuff in mailinfo.c), but the idea sounds delightful. If it's possible to use the battle-tested parts of mailinfo.c without much effort, I'd be in favor of waiting on that. But in case that it's not, I agree with you that we shouldn't let perfect be the enemy of the good[^1], either. Thanks, Taylor [^1]: Though let's make sure that "good" doesn't have any buffer overruns in it ;-)