From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 8077B1F93C for ; Thu, 24 Nov 2022 01:09:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbiKXBJg (ORCPT ); Wed, 23 Nov 2022 20:09:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbiKXBJX (ORCPT ); Wed, 23 Nov 2022 20:09:23 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32CE6ED73A for ; Wed, 23 Nov 2022 17:09:19 -0800 (PST) Received: (qmail 24344 invoked by uid 109); 24 Nov 2022 01:09:18 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 24 Nov 2022 01:09:18 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 21491 invoked by uid 111); 24 Nov 2022 01:09:19 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 23 Nov 2022 20:09:19 -0500 Authentication-Results: peff.net; auth=none Date: Wed, 23 Nov 2022 20:09:17 -0500 From: Jeff King To: Yoichi Nakayama Cc: Yoichi Nakayama via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH v4 2/2] git-jump: invoke emacs/emacsclient Message-ID: References: <2f0bffb484beccf58f2440ed5e2c04a1ba26e6c3.1669126703.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Nov 23, 2022 at 02:33:50PM +0900, Yoichi Nakayama wrote: > On Wed, Nov 23, 2022 at 3:54 AM Jeff King wrote: > > Hmm, I know I suggested using a temporary file since "cat $tmpfile" > > should be pretty safe. But it does still have problems if your tmp > > directory has spaces. Or even other metacharacters, which I think will > > be interpreted by the eval, since $@ is expanded in the outermost level > > of the shell. > > Right. But the problem is not specific to emacs (it happens in vim too). > Let's fix it another time (as you noted, that's pretty unlikely, and we may > not even need to fix it). Good point. The vim version is easier to fix (we just need to double-quote \$1 inside the eval), but the fact that nobody has complained is an indication that it does not really matter. -Peff