From: Jeff King <peff@peff.net>
To: Yoichi Nakayama <yoichi.nakayama@gmail.com>
Cc: Yoichi Nakayama via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v4 2/2] git-jump: invoke emacs/emacsclient
Date: Wed, 23 Nov 2022 20:09:17 -0500 [thread overview]
Message-ID: <Y37EPdUkBhsSPmRD@coredump.intra.peff.net> (raw)
In-Reply-To: <CAF5D8-vSsBsdiA8SiDgqUFkL9_3N-v+psVxj-AcibOB88gxWfA@mail.gmail.com>
On Wed, Nov 23, 2022 at 02:33:50PM +0900, Yoichi Nakayama wrote:
> On Wed, Nov 23, 2022 at 3:54 AM Jeff King <peff@peff.net> wrote:
> > Hmm, I know I suggested using a temporary file since "cat $tmpfile"
> > should be pretty safe. But it does still have problems if your tmp
> > directory has spaces. Or even other metacharacters, which I think will
> > be interpreted by the eval, since $@ is expanded in the outermost level
> > of the shell.
>
> Right. But the problem is not specific to emacs (it happens in vim too).
> Let's fix it another time (as you noted, that's pretty unlikely, and we may
> not even need to fix it).
Good point. The vim version is easier to fix (we just need to
double-quote \$1 inside the eval), but the fact that nobody has
complained is an indication that it does not really matter.
-Peff
next prev parent reply other threads:[~2022-11-24 1:09 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 14:02 [PATCH 0/2] git-jump: support Emacs Yoichi NAKAYAMA via GitGitGadget
2022-11-19 14:02 ` [PATCH 1/2] git-jump: add an optional argument 'stdout' Yoichi Nakayama via GitGitGadget
2022-11-19 14:02 ` [PATCH 2/2] git-jump: invoke emacsclient Yoichi Nakayama via GitGitGadget
2022-11-19 15:53 ` Eric Sunshine
2022-11-19 23:44 ` Yoichi Nakayama
2022-11-19 23:59 ` Eric Sunshine
2022-11-21 4:05 ` Yoichi Nakayama
2022-11-20 1:27 ` [PATCH v2 0/2] git-jump: support Emacs Yoichi NAKAYAMA via GitGitGadget
2022-11-20 1:27 ` [PATCH v2 1/2] git-jump: add an optional argument 'stdout' Yoichi Nakayama via GitGitGadget
2022-11-21 5:43 ` Junio C Hamano
2022-11-21 11:25 ` Yoichi Nakayama
2022-11-21 18:18 ` Jeff King
2022-11-20 1:27 ` [PATCH v2 2/2] git-jump: invoke emacsclient Yoichi Nakayama via GitGitGadget
2022-11-21 12:26 ` [PATCH v3 0/2] git-jump: support Emacs Yoichi NAKAYAMA via GitGitGadget
2022-11-21 12:26 ` [PATCH v3 1/2] git-jump: add an optional argument '--stdout' Yoichi Nakayama via GitGitGadget
2022-11-21 18:38 ` Jeff King
2022-11-21 23:38 ` Junio C Hamano
2022-11-22 13:00 ` Yoichi Nakayama
2022-11-22 18:23 ` Jeff King
2022-11-22 13:29 ` Yoichi Nakayama
2022-11-21 12:27 ` [PATCH v3 2/2] git-jump: invoke emacs/emacsclient Yoichi Nakayama via GitGitGadget
2022-11-21 18:50 ` Jeff King
2022-11-22 12:06 ` Yoichi Nakayama
2022-11-22 14:18 ` [PATCH v4 0/2] git-jump: support Emacs Yoichi NAKAYAMA via GitGitGadget
2022-11-22 14:18 ` [PATCH v4 1/2] git-jump: add an optional argument '--stdout' Yoichi Nakayama via GitGitGadget
2022-11-22 18:30 ` Jeff King
2022-11-22 14:18 ` [PATCH v4 2/2] git-jump: invoke emacs/emacsclient Yoichi Nakayama via GitGitGadget
2022-11-22 16:40 ` Phillip Wood
2022-11-23 5:01 ` Yoichi Nakayama
2022-11-22 18:54 ` Jeff King
2022-11-23 5:33 ` Yoichi Nakayama
2022-11-24 1:09 ` Jeff King [this message]
2022-11-24 12:32 ` Yoichi Nakayama
2022-11-24 12:58 ` Yoichi Nakayama
2022-11-24 16:31 ` Jeff King
2022-11-24 16:29 ` Jeff King
2022-11-25 3:46 ` Yoichi Nakayama
2022-11-23 7:04 ` [PATCH v5 0/3] git-jump: support Emacs Yoichi NAKAYAMA via GitGitGadget
2022-11-23 7:04 ` [PATCH v5 1/3] git-jump: add an optional argument '--stdout' Yoichi Nakayama via GitGitGadget
2022-11-23 7:04 ` [PATCH v5 2/3] git-jump: move valid-mode check earlier Jeff King via GitGitGadget
2022-11-23 7:04 ` [PATCH v5 3/3] git-jump: invoke emacs/emacsclient Yoichi Nakayama via GitGitGadget
2022-11-23 14:58 ` Phillip Wood
2022-11-23 21:54 ` Yoichi Nakayama
2022-11-24 1:11 ` [PATCH v5 0/3] git-jump: support Emacs Jeff King
2022-11-24 3:47 ` [PATCH v6 " Yoichi NAKAYAMA via GitGitGadget
2022-11-24 3:47 ` [PATCH v6 1/3] git-jump: add an optional argument '--stdout' Yoichi Nakayama via GitGitGadget
2022-11-24 3:47 ` [PATCH v6 2/3] git-jump: move valid-mode check earlier Jeff King via GitGitGadget
2022-11-24 3:47 ` [PATCH v6 3/3] git-jump: invoke emacs/emacsclient Yoichi Nakayama via GitGitGadget
2022-11-25 3:36 ` [PATCH v7 0/3] git-jump: support Emacs Yoichi NAKAYAMA via GitGitGadget
2022-11-25 3:36 ` [PATCH v7 1/3] git-jump: add an optional argument '--stdout' Yoichi Nakayama via GitGitGadget
2022-11-25 9:06 ` Ævar Arnfjörð Bjarmason
2022-11-27 0:31 ` Yoichi Nakayama
2022-11-25 3:37 ` [PATCH v7 2/3] git-jump: move valid-mode check earlier Jeff King via GitGitGadget
2022-11-25 3:37 ` [PATCH v7 3/3] git-jump: invoke emacs/emacsclient Yoichi Nakayama via GitGitGadget
2022-11-25 8:55 ` Ævar Arnfjörð Bjarmason
2022-11-25 16:01 ` Yoichi Nakayama
2022-11-25 23:52 ` Ævar Arnfjörð Bjarmason
2022-11-28 5:10 ` Jeff King
2022-11-28 10:54 ` Ævar Arnfjörð Bjarmason
2022-11-28 15:38 ` Yoichi Nakayama
2022-11-27 0:37 ` Yoichi Nakayama
2022-11-27 1:18 ` [PATCH v8 0/3] git-jump: support Emacs Yoichi NAKAYAMA via GitGitGadget
2022-11-27 1:18 ` [PATCH v8 1/3] git-jump: add an optional argument '--stdout' Yoichi Nakayama via GitGitGadget
2022-11-27 1:18 ` [PATCH v8 2/3] git-jump: move valid-mode check earlier Jeff King via GitGitGadget
2022-11-27 1:18 ` [PATCH v8 3/3] git-jump: invoke emacs/emacsclient Yoichi Nakayama via GitGitGadget
2022-11-28 10:13 ` [PATCH v8 0/3] git-jump: support Emacs Phillip Wood
2022-11-28 23:35 ` Junio C Hamano
2022-11-29 21:05 ` Yoichi Nakayama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y37EPdUkBhsSPmRD@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=yoichi.nakayama@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).