From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Zack Weinberg <zack@owlfolio.org>,
phillip.wood@dunelm.org.uk, git@vger.kernel.org
Subject: Re: [bug] git log --invert-grep --grep=[sufficiently complicated regex] prints nothing
Date: Thu, 24 Nov 2022 11:35:16 -0500 [thread overview]
Message-ID: <Y3+dRELMa8AXZ0tZ@coredump.intra.peff.net> (raw)
In-Reply-To: <221124.861qpspckm.gmgdl@evledraar.gmail.com>
On Thu, Nov 24, 2022 at 04:53:28PM +0100, Ævar Arnfjörð Bjarmason wrote:
> This doesn't help with your case, but I remember there being some
> similar confusions and/or expectations mismatches reported in the
> patch. E.g. "--since" here:
> https://lore.kernel.org/git/220401.86pmm1nmvh.gmgdl@evledraar.gmail.com/
>
> I couldn't find a reference quickly, but I seem to recall (but perhaps
> I'm imagining it) that we had a report/discussion semi-recently about:
>
> git log --reverse --follow -- path
>
> Which has a similar edge case, e.g. try on git.git:
>
> git log --reverse --follow -- object-name.c
>
> That's also "correct" if you look at it from the POV of how we implement
> it, i.e. we'll traverse, and the rename to object-name.c is the first
> time we encounter the name from the POV of the walking logic.
I think all of this goes back to Linus's original "--follow is a hack I
bolted on" implementation. It probably should happen up-front as part of
the history simplification. I think it's a combination of nobody wanting
to do the work to extract that, and that it may produce less "streaming"
output, as we have to do a lot more work before producing the first line
of output.
-Peff
prev parent reply other threads:[~2022-11-24 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 20:17 [bug] git log --invert-grep --grep=[sufficiently complicated regex] prints nothing Zack Weinberg
2022-11-24 10:31 ` Phillip Wood
2022-11-24 13:36 ` Zack Weinberg
2022-11-24 15:53 ` Ævar Arnfjörð Bjarmason
2022-11-24 16:35 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3+dRELMa8AXZ0tZ@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).