git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: "Taylor Blau" <me@ttaylorr.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Adam Dinwoodie" <git@dinwoodie.org>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"GIT Mailing-list" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] Makefile: fix cygwin build failure
Date: Wed, 9 Nov 2022 17:58:05 -0500	[thread overview]
Message-ID: <Y2wwfQWrs+KYpWNv@nand.local> (raw)
In-Reply-To: <0dec6e1e-207c-be13-ae95-294d9b1e8831@ramsayjones.plus.com>

Hi Ramsay,

On Wed, Nov 09, 2022 at 10:46:05PM +0000, Ramsay Jones wrote:
> Commit 1c97a5043f (Makefile: define "TEST_{PROGRAM,OBJS}" variables
> earlier, 2022-10-31) breaks the cygwin build, like so:

It seems reasonable to me, and I'd like to pick it up rather quickly (on
top of Ævar's branch), especially if this is going to break things
downstream in Git for Windows.

Ævar: this sort of change is a little tricky to review without more diff
context ;-). Do you have any objections to me slotting this on top of
your branch?

Thanks,
Taylor

  reply	other threads:[~2022-11-09 22:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 22:46 [PATCH] Makefile: fix cygwin build failure Ramsay Jones
2022-11-09 22:58 ` Taylor Blau [this message]
2022-11-09 23:18   ` Ævar Arnfjörð Bjarmason
2022-11-10  2:20     ` Taylor Blau
2022-11-10  2:21       ` Taylor Blau
2022-11-10  2:22         ` Taylor Blau
2022-11-22  1:54           ` Ramsay Jones
2022-11-22  2:02           ` Junio C Hamano
2022-11-10 20:35 ` Adam Dinwoodie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2wwfQWrs+KYpWNv@nand.local \
    --to=me@ttaylorr.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@dinwoodie.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).