git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: M Hickford via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Philip Oakley" <philipoakley@iee.email>,
	"M Hickford" <mirth.hickford@gmail.com>
Subject: Re: [PATCH v3] Mention that password could be a personal access token.
Date: Tue, 8 Nov 2022 16:48:24 -0500	[thread overview]
Message-ID: <Y2rOqP9CxKqlo0dB@nand.local> (raw)
In-Reply-To: <pull.1396.v3.git.1667912487608.gitgitgadget@gmail.com>

On Tue, Nov 08, 2022 at 01:01:27PM +0000, M Hickford via GitGitGadget wrote:
> From: M Hickford <mirth.hickford@gmail.com>
>
> Git asks for a "password", but the user might use a
> personal access token or OAuth access token instead.

Looks good to me. The only minor issue I noticed was that the commit
message should have been prefixed with an area but wasn't.

I changed it to the following when queueing:

    Documentation/gitcredentials.txt: mention password alternatives

Thank you for your work. Let's start merging this one down.

Thanks,
Taylor

      reply	other threads:[~2022-11-08 21:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  4:45 [PATCH] Mention that password could be a personal access token M Hickford via GitGitGadget
2022-10-27 17:40 ` Junio C Hamano
2022-10-27 20:21   ` Jeff King
2022-10-27 21:48     ` Junio C Hamano
2022-11-01  3:54   ` M Hickford
2022-11-01  7:58     ` Ævar Arnfjörð Bjarmason
2022-11-01 10:27       ` M Hickford
2022-11-02 10:30 ` [PATCH v2] " M Hickford via GitGitGadget
2022-11-02 10:54   ` Eric Sunshine
2022-11-02 15:44     ` Junio C Hamano
2022-11-02 15:51       ` Eric Sunshine
2022-11-02 17:30         ` Philip Oakley
2022-11-08 12:11       ` M Hickford
2022-11-08 13:01   ` [PATCH v3] " M Hickford via GitGitGadget
2022-11-08 21:48     ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2rOqP9CxKqlo0dB@nand.local \
    --to=me@ttaylorr.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=mirth.hickford@gmail.com \
    --cc=peff@peff.net \
    --cc=philipoakley@iee.email \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).