git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Derrick Stolee <derrickstolee@github.com>,
	Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] ci: avoid unnecessary builds
Date: Tue, 8 Nov 2022 15:08:33 -0500	[thread overview]
Message-ID: <Y2q3QZDxuywzCexn@nand.local> (raw)
In-Reply-To: <221108.86r0ydqmts.gmgdl@evledraar.gmail.com>

On Tue, Nov 08, 2022 at 07:52:07PM +0100, Ævar Arnfjörð Bjarmason wrote:
> I don't know if there's a workaround for that, I'd think it would be the
> logical equivalent of e.g.:
>
> 	group: sparse-${{ matrix.nr }}-${{ github.ref }}-${{ needs.ci-config.outputs.skip_concurrent ? github.run_id : "" }}

Hmm. Did you mean the opposite of the last part of that expression? IOW,
shouldn't it be:

  ${{ needs.ci-config.outputs.skip_concurrent ? "" : github.run_id }}

That is: if we're cancelling builds when others are in progress, the
group ID shouldn't contain information about the specific run ID. But if
we *aren't* cancelling builds, then the group needs to have the run ID
in it, that way we're effectively disabling the new behavior altogether.

> But the docs say "The expression can only use the github context."[3],
> and I don't know if such a thing would fit inside the syntax...

That's at the workflow level. When you specify a 'concurrency' block
inside of an individual job, you can use any context object excepts the
secrets one [2].

Thanks,
Taylor

[2]: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idconcurrency

  reply	other threads:[~2022-11-08 20:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 18:25 [PATCH 0/1] ci: avoid unnecessary builds, with ci-config Taylor Blau
2022-11-08 18:25 ` [PATCH 1/1] ci: avoid unnecessary builds Taylor Blau
2022-11-08 18:52   ` Ævar Arnfjörð Bjarmason
2022-11-08 20:08     ` Taylor Blau [this message]
2022-11-08 20:09     ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2q3QZDxuywzCexn@nand.local \
    --to=me@ttaylorr.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).