mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <>
To: Jonathan Tan <>
Subject: Re: [PATCH] submodule: explicitly specify on-demand upon push
Date: Mon, 7 Nov 2022 19:31:08 -0500	[thread overview]
Message-ID: <Y2mjTGvBUYpIicFl@nand.local> (raw)
In-Reply-To: <>

On Mon, Nov 07, 2022 at 04:25:52PM -0800, Jonathan Tan wrote:
> This now means that any push.recurseSubmodules configuration in any
> submodule is no longer respected: only the configuration (or CLI
> argument to override it) of the superproject is used. Update the
> documentation accordingly.

Hmm. Is that a desired outcome or an unfortunate side-effect of the
implementation below?

Not having thought about this a lot, the behavior I might expect is
something along the lines of recursively pushing throughout the
submodule tree, stopping the recursion as soon as we get to a nested
submodule which says "don't push any of my children".

On the other hand, I could sympathize with a compelling argument that
the superproject alone should be in charge of determining what gets

Though TBH, it seems like the former is more convincing. If I depend on
an external repository through a submodule, and that repository itself
has submodules, it would be nice to configure (once) that I don't want
to even try and push any of that repository's children.


  reply	other threads:[~2022-11-08  0:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  0:25 [PATCH] submodule: explicitly specify on-demand upon push Jonathan Tan
2022-11-08  0:31 ` Taylor Blau [this message]
2022-11-08 21:43   ` Jonathan Tan
2022-11-09 18:31     ` Glen Choo
2022-11-14 21:37 ` [PATCH v2] Doc: document push.recurseSubmodules=only Jonathan Tan
2022-11-14 21:57   ` Taylor Blau
2022-11-15  0:59   ` Glen Choo
2022-11-15 18:47     ` Jonathan Tan
2022-11-16 21:21       ` Glen Choo
2022-11-16 22:35         ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2mjTGvBUYpIicFl@nand.local \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).