From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 87DFF1F910 for ; Fri, 4 Nov 2022 12:45:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbiKDMon (ORCPT ); Fri, 4 Nov 2022 08:44:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiKDMom (ORCPT ); Fri, 4 Nov 2022 08:44:42 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50E3D6258 for ; Fri, 4 Nov 2022 05:44:41 -0700 (PDT) Received: (qmail 18638 invoked by uid 109); 4 Nov 2022 12:44:40 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 04 Nov 2022 12:44:40 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29400 invoked by uid 111); 4 Nov 2022 12:44:40 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 04 Nov 2022 08:44:40 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 4 Nov 2022 08:44:39 -0400 From: Jeff King To: SZEDER =?utf-8?B?R8OhYm9y?= Cc: =?utf-8?B?THVrw6HFoQ==?= Doktor , Christian Couder , git@vger.kernel.org Subject: Re: "git bisect run" strips "--log" from the list of arguments Message-ID: References: <1cb1c033-0525-7e62-8c09-81019bf26060@redhat.com> <20221104123722.GA6942@szeder.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221104123722.GA6942@szeder.dev> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 04, 2022 at 01:37:22PM +0100, SZEDER Gábor wrote: > This bogus state didn't last long, however, because in the same patch > series 06f5608c14 (bisect--helper: `bisect_start` shell function > partially in C, 2019-01-02) the C reimplementation of bisect_start() > started calling the bisect_write() C function, this time with the > right 'nolog' function parameter. From then on there was no need for > the '--no-log' option in 'bisect--helper'. Eventually all bisect > subcommands were ported to C as 'bisect--helper' command modes, each > calling the bisect_write() C function instead, but when the > '--bisect-write' command mode was removed in 68efed8c8a > (bisect--helper: retire `--bisect-write` subcommand, 2021-02-03) it > forgot to remove that '--no-log' option. Yeah, but I don't think "--log" or "--no-log" is really the bug, is it? The same thing happens if my command is "echo --bisect-run". Obviously that's less likely, but the bug is still that we are parsing random options out of the supposedly opaque command. -Peff