From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 291CC1F910 for ; Tue, 1 Nov 2022 20:55:10 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=ttaylorr-com.20210112.gappssmtp.com header.i=@ttaylorr-com.20210112.gappssmtp.com header.b="RJAwRs3L"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbiKAUyq (ORCPT ); Tue, 1 Nov 2022 16:54:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbiKAUyn (ORCPT ); Tue, 1 Nov 2022 16:54:43 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5217B10579 for ; Tue, 1 Nov 2022 13:54:40 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id d123so8680638iof.7 for ; Tue, 01 Nov 2022 13:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=meIcIA8MWO1NLFgjGrne1Y+8Dlz3wfNZwrYN1+YZHM8=; b=RJAwRs3LefnubvLakjvl7k3cnfM82F045Qx7LQZyTSNq5/euEPI8XMU7nKLkMuUADr 7r/AwX+4Z1rj0q/L57cTemU1RKEPZ3ZHncdec1FnuXNhHtT5gRYO1HHCedA0/JQ+qLeZ jnXBLaaUir9PKKCHZxBOS61MEWVcnT7iFwaaV7MVyVl73uv+2v3xUqcZXOxc+/r6+MI2 Wqp8G1kISQvH/v6jjbRwYiSO2Xzm5xZrg+ZfwrjJBLEaht3Pt8auC64fNEyvSbdCSvJg Xtbuk76A9BLduQCRukp6+XxxQDqF+LjpjDLCqplFJdMKxAsnutzZpTngDLwtYROLrJpV w4iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=meIcIA8MWO1NLFgjGrne1Y+8Dlz3wfNZwrYN1+YZHM8=; b=MY6cG+XZlQ83aA1MxNQW5b9I4aJlSMdWWtu1WbuvUyCg53R1j2dCQEXLNKwYnC+ijt pRbJ8mLhCux4KSSmbK8d4PHjXxYi529LopqbQL7hr3t66bp5sUuzJz4YOhBkubFO5chY +Y/ErlPmYZ/aCiv74NJpm6v8qkWzYV9CPb2CM99ccAzcUJ5s8exMb13ozIWIv35lOg7g +v3woM3PaMF9Xz0h2h/rHqghtC/nvzcsTEqPwElfn8Anq65gXnvsxBsVbEAlPuKgjpJH paajLynd/dwKxUxzbyDB2kTEf5onzkq0z7zjKKgOaUZQE5q/OHxaLnGBwPnOH3zO2qQU aYDw== X-Gm-Message-State: ACrzQf2Q03/nMymshHolh97JcL4zf8KhbDINv7UgbkOXLFwEernsf6j4 TkmQvjWckPi+nAkbnbRcOkkbBQ== X-Google-Smtp-Source: AMsMyM5v+TCnzsQZI0NR+mlaUqiFZqi/LZaJw0RidXQvaN6He9bG9g5DIp6CSFmx68WkjTYI9wOk+A== X-Received: by 2002:a02:cc71:0:b0:373:1604:274d with SMTP id j17-20020a02cc71000000b003731604274dmr12801493jaq.119.1667336079663; Tue, 01 Nov 2022 13:54:39 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id y88-20020a029561000000b00363aefdf040sm4209343jah.83.2022.11.01.13.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 13:54:39 -0700 (PDT) Date: Tue, 1 Nov 2022 16:54:38 -0400 From: Taylor Blau To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Jeff King , git@vger.kernel.org, Junio C Hamano , Taylor Blau , Derrick Stolee , Johannes Schindelin Subject: Re: [RFC PATCH] fetch: stop emitting duplicate transfer.credentialsInUrl=warn warnings Message-ID: References: <221101.86a65b5q9q.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <221101.86a65b5q9q.gmgdl@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Nov 01, 2022 at 04:01:18AM +0100, Ævar Arnfjörð Bjarmason wrote: > > Yeah, I think it is crappy UX, too. It's just that I think the tests > > should not _asserting_ the bad behavior. At most, they should tolerate > > the bad behavior as a band-aid. So I think Dscho's patch is doing the > > right thing (and I do agree that we should fix the immediate CI pain by > > adjusting the tests, and letting the user-visible fix proceed > > independently). > > The tests aren't just asserting the bad behavior, they're also ensuring > that it doesn't get worse. 1 warning is ideal, 2-3 is bad, but > tolerable, but if we start emitting 500 of these it would be nice to > know. I admit that this kind of argument does not sway me. Is it likely that we would suddenly start spewing 500 such warnings? If we did, are there no other tests that would catch it? And even if *that* were the case, would nobody happen to notice it in the meantime either during development or when we queue an affected topic onto 'next' for wider testing? I guess the answer is that it's possible that we'd miss such a regression in all of those above places, but to me it seems extremely unlikely that we'd let such a regression through without noticing. Thanks, Taylor