From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 97C691F910 for ; Tue, 1 Nov 2022 02:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229500AbiKACED (ORCPT ); Mon, 31 Oct 2022 22:04:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiKACEB (ORCPT ); Mon, 31 Oct 2022 22:04:01 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5523AF35 for ; Mon, 31 Oct 2022 19:04:00 -0700 (PDT) Received: (qmail 3856 invoked by uid 109); 1 Nov 2022 02:03:59 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 01 Nov 2022 02:03:59 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 17949 invoked by uid 111); 1 Nov 2022 02:04:00 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 31 Oct 2022 22:04:00 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 31 Oct 2022 22:03:58 -0400 From: Jeff King To: Johannes Schindelin via GitGitGadget Cc: git@vger.kernel.org, Derrick Stolee , Johannes Schindelin Subject: Re: [PATCH 1/2] t5516/t5601: avoid using `localhost` for failing HTTPS requests Message-ID: References: <25cc0f6d91a9d23eb1b755e1463d672e4958a4e9.1667245639.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Oct 31, 2022 at 07:20:11PM -0400, Jeff King wrote: > > - The DNS resolver, or the local firewall, might take a substantial > > amount of time (or forever, whichever comes first) to fail to connect, > > slowing down the test cases unnecessarily. > > Right. I think we assume that DNS resolution of localhost is fast-ish, > as we use it in other https tests. But I could certainly imagine a local > firewall causing issues (especially as this is real port 443, whereas > our other tests are usually high ports). Actually, I am wrong about DNS here. We use a bare 127.0.0.1 in lib-httpd.sh, so DNS may indeed be the source of the issue here. That _might_ mean that using the bare IP would be safe here, but I would not want to bet on it. Using different port numbers, plus not expecting a listener on the other end, might cause different outcomes than we see in the other tests. I do think moving these tests to use a real http server is a better solution, though. I'll provide a patch in a moment. -Peff