git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] tests(scalar): tighten the stale `scalar.repo` test some
Date: Fri, 11 Nov 2022 17:25:27 -0500	[thread overview]
Message-ID: <Y27L1+tS8yvGlMSZ@nand.local> (raw)
In-Reply-To: <83b9ff0b-a655-714e-a8f9-44b0d1ac3177@github.com>

On Thu, Nov 10, 2022 at 08:56:41AM -0500, Derrick Stolee wrote:
> On 11/10/2022 2:28 AM, Johannes Schindelin via GitGitGadget wrote:
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > As pointed out by Stolee, the previous incarnation of this test case was
> > not stringent enough: we want to verify that _only_ the stale entries
> > are removed (previously, the test case would have succeeded even if all
> > entries had been removed).
>
> Thanks for tightening the test!

Thanks, both. I merged this back into 'js/remove-stale-scalar-repos' and
will re-merge it back into 'next' during the next push-out (probably on
Monday or Tuesday of next week).

Thanks,
Taylor

      reply	other threads:[~2022-11-11 22:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  7:28 [PATCH] tests(scalar): tighten the stale `scalar.repo` test some Johannes Schindelin via GitGitGadget
2022-11-10 13:56 ` Derrick Stolee
2022-11-11 22:25   ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y27L1+tS8yvGlMSZ@nand.local \
    --to=me@ttaylorr.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).