From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 136011F910 for ; Fri, 11 Nov 2022 15:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233981AbiKKPUQ (ORCPT ); Fri, 11 Nov 2022 10:20:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233478AbiKKPTp (ORCPT ); Fri, 11 Nov 2022 10:19:45 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AF7D833B3 for ; Fri, 11 Nov 2022 07:19:31 -0800 (PST) Received: (qmail 372 invoked by uid 109); 11 Nov 2022 15:19:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 11 Nov 2022 15:19:31 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 5938 invoked by uid 111); 11 Nov 2022 15:19:30 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 11 Nov 2022 10:19:30 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 11 Nov 2022 10:19:30 -0500 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Glen Choo , Taylor Blau , Glen Choo via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH] t: run t5551 tests with both HTTP and HTTP/2 Message-ID: References: <221111.86wn81mssk.gmgdl@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <221111.86wn81mssk.gmgdl@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 11, 2022 at 04:06:20PM +0100, Ævar Arnfjörð Bjarmason wrote: > > In theory other http-related test scripts could benefit from the same > > duplication, but doing t5551 should give us a reasonable check of basic > > functionality, and would have caught both bugs we've seen in the wild > > with HTTP/2. > > Looking at the diff below, would it be much more work to just support a > GIT_TEST_HTTP_VERSION=2? No, but 99% of the tests would not benefit (because they don't run http at all), and it would consume a bunch of extra CPU. > There's the "!HTTP2" additions, which you mention you'll be "fixing > momentarily", but this is a stand-alone patch, so maybe I'm missing that > context... The other context is Glen's patch that started this thread. -Peff