From: "brian m. carlson" <email@example.com>
To: Eric Sunshine <firstname.lastname@example.org>
Cc: "Eric Sunshine via GitGitGadget" <email@example.com>,
firstname.lastname@example.org, "Jeff King" <email@example.com>,
"Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org>
Subject: Re: [PATCH 1/3] chainlint: sidestep impoverished macOS "terminfo"
Date: Thu, 10 Nov 2022 22:21:24 +0000 [thread overview]
Message-ID: <Y215ZKz2iZWJCYo3@tapette.crustytoothpaste.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]
On 2022-11-10 at 03:37:16, Eric Sunshine wrote:
> Hmm, on my machine "nsterm" also lacks the "dim" capability. I see
> that Neovim docs recommend "nsterm" with Terminal.app, so perhaps that
> ought to be handled specially here, as well. Do you think any
> variations other than base "nsterm" are worth special-casing?
I'd say we should do nsterm, nsterm-256color, and nsterm-direct.
> I don't mind tightening which terminal types are handled specially.
> "xterm-direct" doesn't exist on my old macOS. Is it present on newer
> macOS? If so, does it require special-casing (i.e. does it lack
> "dim")? If we don't special-case "xterm-direct", it will fall back to
> using `tput` interrogation, which should be fine as long as the
> "xterm-direct" terminfo entry is accurate.
It's present in newer ncurses, so I expect it will make its way to macOS
eventually. I don't know whether Apple's version of it will contain
the `dim` capability, but on Debian all three xterm variants do.
It sounds like Apple is specifically limiting their capabilities for
some reason when upstream ncurses doesn't. I can't say why that is, but
perhaps it's for compatibility. Debian had to do that for one release
with screen* when Screen added support for some new feature but tmux had
> I notice that the iTerm2 FAQ also recommends "xterm-new" on macOS, and
> that one lacks "dim", as well on my machine. So, it seems that it
> should be special-cased too.
> Taking all the above into account, perhaps this regex?
Maybe this, then?
That matches the three special variants of each one here plus xterm-new.
> Of course, the other option is to follow Git's own lead by not
> worrying about TERM and `tput` and just assume everyone understands
> ANSI color codes. I'm too old-school to feel entirely comfortable with
> that approach, but I would entertain it if others feel it is safe
Sure. I would also prefer to avoid that.
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2022-11-10 22:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 16:58 [PATCH 0/3] chainlint: emit line numbers alongside test definitions Eric Sunshine via GitGitGadget
2022-11-09 16:58 ` [PATCH 1/3] chainlint: sidestep impoverished macOS "terminfo" Eric Sunshine via GitGitGadget
2022-11-09 22:18 ` Taylor Blau
2022-11-10 2:40 ` brian m. carlson
2022-11-10 3:37 ` Eric Sunshine
2022-11-10 22:21 ` brian m. carlson [this message]
2022-11-10 22:36 ` Eric Sunshine
2022-11-10 22:48 ` brian m. carlson
2022-11-09 16:58 ` [PATCH 2/3] chainlint: latch line numbers at which each token starts and ends Eric Sunshine via GitGitGadget
2022-11-09 16:58 ` [PATCH 3/3] chainlint: prefix annotated test definition with line numbers Eric Sunshine via GitGitGadget
2022-11-09 22:22 ` [PATCH 0/3] chainlint: emit line numbers alongside test definitions Taylor Blau
2022-11-11 7:34 ` [PATCH v2 " Eric Sunshine via GitGitGadget
2022-11-11 7:34 ` [PATCH v2 1/3] chainlint: sidestep impoverished macOS "terminfo" Eric Sunshine via GitGitGadget
2022-11-11 14:55 ` Ævar Arnfjörð Bjarmason
2022-11-11 16:44 ` Eric Sunshine
2022-11-11 17:15 ` Eric Sunshine
2022-11-11 21:56 ` Taylor Blau
2022-11-11 7:34 ` [PATCH v2 2/3] chainlint: latch line numbers at which each token starts and ends Eric Sunshine via GitGitGadget
2022-11-11 7:34 ` [PATCH v2 3/3] chainlint: prefix annotated test definition with line numbers Eric Sunshine via GitGitGadget
2022-11-11 15:03 ` [PATCH 0/3] chainlint: emit line numbers alongside test definitions Ævar Arnfjörð Bjarmason
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).