From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: kpcyrd <kpcyrd@archlinux.org>
Cc: rb-general@lists.reproducible-builds.org,
arch-dev-public@lists.archlinux.org, git@vger.kernel.org,
gitster@pobox.com, l.s.r@web.de
Subject: Re: git 2.38.0: Change in `git archive` output
Date: Sun, 16 Oct 2022 23:21:09 +0000 [thread overview]
Message-ID: <Y0yR5dPJyh8aetZA@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <20b14207-a6f2-033f-3419-271662bffba9@archlinux.org>
[-- Attachment #1: Type: text/plain, Size: 2229 bytes --]
On 2022-10-16 at 21:57:40, kpcyrd wrote:
> hello,
Hey,
> multiple people in Arch Linux noticed the output of our `git archive`
> command doesn't match the tarball served by github anymore.
>
> First I suspected an update in our gzip package until I found this line in
> the git 2.38.0 release notes:
>
> > * Teach "git archive" to (optionally and then by default) avoid
> > spawning an external "gzip" process when creating ".tar.gz" (and
> > ".tgz") archives.
>
> I've then found this commit that could be considered a breaking change in
> `git archive`:
>
> https://github.com/git/git/commit/4f4be00d302bc52d0d9d5a3d4738bb525066c710
>
> I don't know if there's some kind of gzip standard that could be used to
> align the git internal gzip implementation with gnu gzip.
>
> I'm not saying this is necessarily a bug or regression but it makes it
> harder to reproduce github tar balls from a git repository. Just sharing
> what I've debugged. :)
This isn't a bug, because Git doesn't guarantee that archives produced
by different versions will be bit-for-bit identical. It does guarantee
that an archive of the same commit or tree using the same version of Git
and associated tools running with the same configuration and environment
will be consistent (that is, a given version of Git produces
deterministic archives).
I will also point out that GitHub also doesn't guarantee bit-for-bit
identical archives. It does currently use git archive under the hood,
but that could change at any moment without notice.
Zip files also contain two sets of timestamps: local and UTC, and
therefore there's an additional element in which archives can differ
depending on the time zone. In addition, using the export-subst
functionality can result in short object IDs of different lengths
depending on the number of objects in the repository, so archive can
differ for that reason as well.
So it's not the case that you can expect identical archives from Git and
GitHub. If you need to compute a hash over an archive, you need to
store the archive somewhere (on GitHub, that would be as a release
asset).
--
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2022-10-16 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 21:57 git 2.38.0: Change in `git archive` output kpcyrd
2022-10-16 23:21 ` brian m. carlson [this message]
2022-10-17 0:02 ` Jeff King
2022-10-17 0:51 ` brian m. carlson
2022-10-17 17:03 ` Jeff King
2022-10-17 19:14 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0yR5dPJyh8aetZA@tapette.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=arch-dev-public@lists.archlinux.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kpcyrd@archlinux.org \
--cc=l.s.r@web.de \
--cc=rb-general@lists.reproducible-builds.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).