git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Derrick Stolee <derrickstolee@github.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 4alt/4] attr: drop DEBUG_ATTR code
Date: Mon, 10 Oct 2022 20:26:53 -0400	[thread overview]
Message-ID: <Y0S4TWdeK0dSL3VZ@coredump.intra.peff.net> (raw)
In-Reply-To: <fb4cfbd3-e738-f1e8-18f7-d4e90050b8b5@github.com>

On Thu, Oct 06, 2022 at 02:33:08PM -0400, Derrick Stolee wrote:

> Are you implying that you want to use the second version, that
> deletes the information entirely? I'm leaning towards deleting
> it.
> 
> If not, and we should keep using traces, I do notice that the
> original version of the patch uses trace_printf_key() instead
> of a trace2 method. I think this is fine, too, since it's
> likely only to be used by Git developers, who could look for
> which type of trace to use.

I think it's moot, because we're all in agreement that the code should
be deleted. But...

...it is not clear to me that GIT_TRACE_* is dead for further additions.
I find it delightfully simple to use, and trace2 often rather baroque
and complicated, since it is aimed more at structured data, as well as
storing or even transmitting data.

I'm not sure if we have an overall plan there.

-Peff

  parent reply	other threads:[~2022-10-11  0:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 13:09 [PATCH 0/4] a few small unused-parameter fixes Jeff King
2022-10-06 13:10 ` [PATCH 1/4] test-submodule: inline resolve_relative_url() function Jeff King
2022-10-06 13:10 ` [PATCH 2/4] multi-pack-index: avoid writing to global in option callback Jeff King
2022-10-06 13:11 ` [PATCH 3/4] commit: " Jeff King
2022-10-06 13:13 ` [PATCH 4/4] attr: convert DEBUG_ATTR to use trace API Jeff King
2022-10-06 13:23   ` [PATCH 4alt/4] attr: drop DEBUG_ATTR code Jeff King
2022-10-06 17:02     ` Junio C Hamano
2022-10-06 18:33       ` Derrick Stolee
2022-10-06 18:52         ` Junio C Hamano
2022-10-11  0:26         ` Jeff King [this message]
2022-10-11  0:23       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0S4TWdeK0dSL3VZ@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).