From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id AE2501F403 for ; Tue, 11 Oct 2022 00:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229472AbiJKAXs (ORCPT ); Mon, 10 Oct 2022 20:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiJKAXr (ORCPT ); Mon, 10 Oct 2022 20:23:47 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A379804B0 for ; Mon, 10 Oct 2022 17:23:45 -0700 (PDT) Received: (qmail 29711 invoked by uid 109); 11 Oct 2022 00:23:45 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 11 Oct 2022 00:23:45 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 15149 invoked by uid 111); 11 Oct 2022 00:23:46 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 10 Oct 2022 20:23:46 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 10 Oct 2022 20:23:44 -0400 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org Subject: Re: [PATCH 4alt/4] attr: drop DEBUG_ATTR code Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Oct 06, 2022 at 10:02:33AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Thu, Oct 06, 2022 at 09:13:41AM -0400, Jeff King wrote: > > > >> The other obvious option is to just delete this debug code, and remove > >> the unused parameter. I'm not sure if the trace would ever be useful or > >> not, and I am mostly retaining it out of the logic of "well, somebody > >> bothered to write it". I think the const issue has been there since > >> e810e06357 (attr: tighten const correctness with git_attr and > >> match_attr, 2017-01-27). > > > > And here's what that would look like. > > I highly suspect that I was the one who bothered, and while I admit > it was useful while developing the attribute subsystem, I haven't > needed it for the past 10 or so years. It was indeed you. :) I am quite happy to delete the code (via 4alt), but didn't want to step on any toes. -Peff