From: Jeff King <peff@peff.net>
To: Jacob Stopak <jacob@initialcommit.io>
Cc: Taylor Blau <me@ttaylorr.com>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, martin.agren@gmail.com
Subject: Re: [RFC PATCH v2] shortlog: add group-by options for year and month
Date: Mon, 10 Oct 2022 20:59:08 -0400 [thread overview]
Message-ID: <Y0S/3Nl6PFWS3rTd@coredump.intra.peff.net> (raw)
In-Reply-To: <Yz93RjrJ00A5QvNe.jacob@initialcommit.io>
On Thu, Oct 06, 2022 at 05:48:06PM -0700, Jacob Stopak wrote:
> > We probably want to insist that the format contains a "%" sign, and/or
> > git it a keyword like "format:". Otherwise a typo like:
> >
> > git shortlog --format=autor
> >
> > stops being an error we detect, and just returns nonsense results
> > (every commit has the same ident).
>
> Small aside: I like how Taylor re-used the --group option for the custom format.
> IMO it hammers home that this is a grouping option and not just formatting or
> filtering which can be confusing to users sometimes when doing data analytics.
Yeah, sorry this was just a typo/thinko on my part. It absolutely should
be --group, as --format already does something else.
-Peff
next prev parent reply other threads:[~2022-10-11 0:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 6:18 [RFC PATCH] shortlog: add group-by options for year and month Jacob Stopak
2022-09-22 15:46 ` Martin Ågren
2022-09-22 23:25 ` [RFC PATCH v2] " Jacob Stopak
2022-09-23 16:17 ` Junio C Hamano
2022-09-23 21:19 ` Jacob Stopak
2022-09-23 21:58 ` Jeff King
2022-09-23 22:06 ` Junio C Hamano
2022-09-24 4:38 ` Jacob Stopak
2022-10-05 22:14 ` Jeff King
2022-10-05 21:43 ` Taylor Blau
2022-10-05 22:26 ` Jeff King
2022-10-07 0:48 ` Jacob Stopak
2022-10-07 21:59 ` Taylor Blau
2022-10-11 0:59 ` Jeff King [this message]
2022-10-07 22:24 ` Taylor Blau
2022-10-11 1:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0S/3Nl6PFWS3rTd@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob@initialcommit.io \
--cc=martin.agren@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).