From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/12] more unused-parameter fixes / annotations
Date: Mon, 17 Oct 2022 21:00:50 -0400 [thread overview]
Message-ID: <Y036whEorZV0rOgB@coredump.intra.peff.net> (raw)
Here's another batch of UNUSED markings. I've floated the less-obvious
ones to the top. Patches 4-12 are trivially correct in the sense that
the compiler would tell us if we were wrong about it being unused. But I
tried where appropriate to reason out why ignoring a parameter wasn't an
unintentional bug.
[01/12]: diffstat_consume(): assert non-zero length
[02/12]: submodule--helper: drop unused argc from module_list_compute()
[03/12]: update-index: drop unused argc from do_reupdate()
[04/12]: mark unused parameters in trivial compat functions
[05/12]: object-file: mark unused parameters in hash_unknown functions
[06/12]: string-list: mark unused callback parameters
[07/12]: date: mark unused parameters in handler functions
[08/12]: apply: mark unused parameters in handlers
[09/12]: apply: mark unused parameters in noop error/warning routine
[10/12]: convert: mark unused parameter in null stream filter
[11/12]: diffcore-pickaxe: mark unused parameters in pickaxe functions
[12/12]: ll-merge: mark unused parameters in callbacks
apply.c | 18 +++++++++---------
archive.c | 2 +-
builtin/gc.c | 2 +-
builtin/remote.c | 2 +-
builtin/submodule--helper.c | 18 +++++++++---------
builtin/update-index.c | 6 +++---
compat/nonblock.c | 2 +-
convert.c | 4 ++--
date.c | 6 +++---
diff.c | 3 +++
diffcore-pickaxe.c | 4 ++--
exec-cmd.c | 2 +-
git-compat-util.h | 16 ++++++++++------
ll-merge.c | 18 +++++++++---------
merge-ort.c | 2 +-
object-file.c | 15 ++++++++++-----
reflog-walk.c | 2 +-
string-list.c | 2 +-
t/helper/test-path-utils.c | 3 ++-
19 files changed, 70 insertions(+), 57 deletions(-)
-Peff
next reply other threads:[~2022-10-18 1:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 1:00 Jeff King [this message]
2022-10-18 1:01 ` [PATCH 01/12] diffstat_consume(): assert non-zero length Jeff King
2022-10-18 1:02 ` [PATCH 02/12] submodule--helper: drop unused argc from module_list_compute() Jeff King
2022-10-18 1:04 ` [PATCH 03/12] update-index: drop unused argc from do_reupdate() Jeff King
2022-10-18 1:05 ` [PATCH 04/12] mark unused parameters in trivial compat functions Jeff King
2022-10-18 1:05 ` [PATCH 05/12] object-file: mark unused parameters in hash_unknown functions Jeff King
2022-10-18 1:05 ` [PATCH 06/12] string-list: mark unused callback parameters Jeff King
2022-10-18 1:05 ` [PATCH 07/12] date: mark unused parameters in handler functions Jeff King
2022-10-18 1:08 ` [PATCH 08/12] apply: mark unused parameters in handlers Jeff King
2022-10-18 1:08 ` [PATCH 09/12] apply: mark unused parameters in noop error/warning routine Jeff King
2022-10-18 1:08 ` [PATCH 10/12] convert: mark unused parameter in null stream filter Jeff King
2022-10-18 1:09 ` [PATCH 11/12] diffcore-pickaxe: mark unused parameters in pickaxe functions Jeff King
2022-10-18 1:10 ` [PATCH 12/12] ll-merge: mark unused parameters in callbacks Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y036whEorZV0rOgB@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).